Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't link to raw.github.com images and resources, deploy them with the site #663

Closed
8 tasks done
Tracked by #1052
chalin opened this issue Aug 12, 2021 · 3 comments · Fixed by #2379
Closed
8 tasks done
Tracked by #1052

Don't link to raw.github.com images and resources, deploy them with the site #663

chalin opened this issue Aug 12, 2021 · 3 comments · Fixed by #2379
Labels
bug Something isn't working CI/infra CI & infrastructure cleanup/refactoring e1-hours Effort: < 8 hrs e2-days Effort: < 5 days p2-medium p3-low

Comments

@chalin
Copy link
Contributor

chalin commented Aug 12, 2021

For example see, https://github.com/open-telemetry/opentelemetry.io/blame/main/content/en/docs/_index.md#L36:

<img src="https://raw.github.com/open-telemetry/opentelemetry.io/main/iconography/Reference_Architecture.svg" alt="Implementation of the OpenTelemetry Reference Architecture "></img>

Edit: I'm generalizing this to don't serve resources from GH. Another example is the iconography.zip.

Serve all of the following resources from the production server, not GH:

Related:

@chalin chalin added bug Something isn't working CI/infra CI & infrastructure e1-hours Effort: < 8 hrs e2-days Effort: < 5 days p2-medium cleanup/refactoring labels Aug 12, 2021
@chalin chalin changed the title Don't serve site images from raw.github.com, deploy them with the site Don't link to raw.github.com images and resources, deploy them with the site Aug 12, 2021
@chalin chalin mentioned this issue Sep 23, 2021
32 tasks
@chalin chalin added the p3-low label Aug 19, 2022
@svrnm
Copy link
Member

svrnm commented Aug 30, 2022

it looks like the whole issue comes down to images being located in iconography.

@chalin, @cartermp: could we just move those images to static/ or any other folder that will be published or are we going to break things?

@chalin
Copy link
Contributor Author

chalin commented Feb 20, 2023

@svrnm - see #2367

@chalin
Copy link
Contributor Author

chalin commented Feb 20, 2023

Once the Go docs have been updated and brought into this repo, we can close this issue.

This was referenced Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/infra CI & infrastructure cleanup/refactoring e1-hours Effort: < 8 hrs e2-days Effort: < 5 days p2-medium p3-low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants