Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles/follow up: consistent time format #253

Closed
florianl opened this issue Mar 6, 2024 · 5 comments
Closed

profiles/follow up: consistent time format #253

florianl opened this issue Mar 6, 2024 · 5 comments

Comments

@florianl
Copy link
Contributor

florianl commented Mar 6, 2024

This is a follow up for #239 (comment) around the request for a consistent time precision:

In ProfileContainer there are start_time_unix_nano and end_time_unix_nano. Should we have the same precision with timestamps in Sample and also use ns instead of ms?

// Timestamps associated with Sample represented in ms. These timestamps are expected
// to fall within the Profile's time range. [optional]
repeated uint64 timestamps = 13;

With Profile.time_nanos there is another timestamp in the message that uses nanosecond precision.

@arminru
Copy link
Member

arminru commented Mar 25, 2024

cc @open-telemetry/profiling-maintainers @open-telemetry/profiling-approvers

@mtwo
Copy link
Member

mtwo commented Mar 25, 2024

Comment from the OTel maintainer meeting: could / should this be moved to a comment on the current Profiling PR in the OTLP repository?

@florianl
Copy link
Contributor Author

This issue is linked in open-telemetry/opentelemetry-proto#534 (comment). As this particular issue is relevant to the specification, I did open the issue in this repository.

@petethepig
Copy link
Member

Addressed in open-telemetry/opentelemetry-proto@f5b5897

@florianl
Copy link
Contributor Author

Closing issue as resolved with open-telemetry/opentelemetry-proto@f5b5897.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants