-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use consistent suffix for JVM Metrics #288
Comments
so we would probably need to have that discussion ( I personally think either nouns or adjectives (when it describes the namespace which is a noun) seem like good metric names, e.g.
|
I realized, I don't think we would want to rename
@lenin-jaganathan wdyt? do you want to keep this issue open? thx |
I would still like this to be addressed. There is a subtle difference between As you mentioned, the first metric has multiple states - used, free, cached, etc. But the JVM metric is all about using part of it and we have separate metrics for committed, limit, etc. But even in the system metrics use-case, |
ya, this is being addressed in #409:
can you re-summarize your reasoning for renaming |
ah, I think I understand now
|
same would apply to |
looking at other
|
There seem to be two options for Option 1Rename Option 2Keep the name, but add
and remove the |
I don't think I got Option 2 right above. I think
In which case we'd probably leave |
Discussed in Java SIG meeting today:
|
While going through
semantic-conventions/docs/jvm/jvm-metrics.md
Lines 15 to 38 in 4bbb8c9
I propose replacing the suffix "usage" (noun) in the following metrics with "used" (verb),
All these represent the amount being used. In addition, the description already uses the word "used" to describe these metrics and the JMX methods also use the word "used". Also, the sibling metrics use the verb form. E.g: "jvm.memory.committed"
The text was updated successfully, but these errors were encountered: