Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The protocol attribute should be removed for system.network.connections metrics #649

Open
codeboten opened this issue Sep 14, 2022 · 3 comments

Comments

@codeboten
Copy link

What are you trying to achieve?

Since UDP has no state, I propose UDP and TCP connection metrics should be split into protocol specific metric for each supported protocol.

If folks agree, I will open a PR to mark system.network.connections as deprecated in favour of:

system.network.tcp.connections
system.network.udp.connections

Additional context.

The work for this was previously done in open-telemetry/opentelemetry-specification#2675 and reverted in open-telemetry/opentelemetry-specification#2748. See open-telemetry/opentelemetry-specification#2726 for additional context

@mx-psi
Copy link
Member

mx-psi commented Jan 18, 2024

@jsuereth Can we transfer this to the semantic-conventions repository?

@dmitryax
Copy link
Member

@codeboten, is this still applicable after the revert is done in open-telemetry/opentelemetry-specification#2726? Can we close it now?

@arminru arminru transferred this issue from open-telemetry/opentelemetry-specification Jan 18, 2024
@mx-psi
Copy link
Member

mx-psi commented Mar 22, 2024

@codeboten Can you help us with the question above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants