Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote write compliance: TestRemoteWrite/otelcollector/Staleness #38

Closed
rakyll opened this issue Apr 20, 2021 · 5 comments
Closed

Remote write compliance: TestRemoteWrite/otelcollector/Staleness #38

rakyll opened this issue Apr 20, 2021 · 5 comments
Assignees
Labels
conformance testing PRW conformance testing issue or PR P0 An issue that needs to be addressed immediately. Breaking change. phase1 phase1 tasks prom-exporter Prometheus exporter tasks

Comments

@rakyll
Copy link
Contributor

rakyll commented Apr 20, 2021

The OpenTelemetry collector is not passing https://github.com/prometheus/compliance/tree/main/remote_write TestRemoteWrite/otelcollector/Staleness.

=== CONT  TestRemoteWrite/otelcollector/Staleness
    staleness.go:43:
        	Error Trace:	staleness.go:43
        	            				main_test.go:101
        	            				main_test.go:65
        	Error:      	Should be true
        	Test:       	TestRemoteWrite/otelcollector/Staleness
        	Messages:   	found no staleness markers for stale{job="test"}
@rakyll rakyll changed the title Remote write compatibility: TestRemoteWrite/otelcollector/Staleness Remote write compliance: TestRemoteWrite/otelcollector/Staleness Apr 20, 2021
@rakyll rakyll added phase1 phase1 tasks prom-exporter Prometheus exporter tasks labels Apr 20, 2021
@rakyll rakyll added the P0 An issue that needs to be addressed immediately. Breaking change. label Apr 20, 2021
@alolita
Copy link
Member

alolita commented May 12, 2021

@rakyll pl advise what needs to be done to resolve this issue?

@alolita alolita added the conformance testing PRW conformance testing issue or PR label May 20, 2021
@alolita
Copy link
Member

alolita commented Jun 2, 2021

@punya is someone on your team available to work on this issue? This is a blocker for PRW compliance. Perhaps Fabian could take a look and advise?

@punya
Copy link
Member

punya commented Jun 2, 2021

@alolita let me get back to you this week.

@punya
Copy link
Member

punya commented Jun 9, 2021

Fabian is on vacation until June 14th. I'll ask around if there are other Prometheus experts who can weigh in.

@odeke-em
Copy link
Member

odeke-em commented Jul 8, 2021

Fixed by open-telemetry/opentelemetry-collector#3423 and now we are 100% passing :-) @alolita or @rakyll, please close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conformance testing PRW conformance testing issue or PR P0 An issue that needs to be addressed immediately. Breaking change. phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Projects
None yet
Development

No branches or pull requests

5 participants