Skip to content
This repository has been archived by the owner on Sep 24, 2019. It is now read-only.

Remove unnecessary null pointer checks #33

Open
elfring opened this issue Feb 22, 2014 · 2 comments
Open

Remove unnecessary null pointer checks #33

elfring opened this issue Feb 22, 2014 · 2 comments

Comments

@elfring
Copy link

elfring commented Feb 22, 2014

An extra null pointer check is not needed in functions like the following.
@randy-waterhouse
Copy link
Contributor

Essentially it is a style choice for to have safe code. Also the coding around NULL pointer checks is being reviewed as the transition to pure C++11 code is carried out.

@elfring
Copy link
Author

elfring commented May 15, 2014

Unnecessary checks have got unwanted effects on run time behaviour. They will not make the source code safer in this use case.
Their relevance will vary with the call frequency for the affected functions.

Would you like to wrap any pointer data members with the template class "std::unique_ptr"?

da2ce7 pushed a commit to da2ce7/Open-Transactions that referenced this issue Aug 10, 2014
@murrekatt
Merge pull request Open-Transactions#33 from murrekatt/develop
8e5897f 
Removed ssl and osx subdirs. Minor cleanup of build_tar.sh script and some source files.
da2ce7 pushed a commit to da2ce7/Open-Transactions that referenced this issue Sep 6, 2014
@lclc
Merge pull request Open-Transactions#33 from da2ce7/cmake_inc_headers
d256627 
add headers to cmake
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@randy-waterhouse @elfring