How can the code be improved

[AzimzadaMurad]

Please 🙏 make review my test case and code in Cypress.

It should retrieve users

1. Get users by method GET https://reqres.in/api/users?page=2
2. Users should be with status 200
3. Users should have some keys
4. id should be a number
5. First name should don't be an empty
6. Last name should don't be an empty
7. Email should include symbol @
8. Avatar should be match /^https/
9. Support URL should match /^https/
10. Support text should don't be empty

Test on Cypress ~/cypress/integration/users-api.spec.js

describe('API', () => {

  it("Testing Method Get List User", () => {
    cy.api("GET", "https://reqres.in/api/users?page=2").then(
      ({ status, body }) => {
        expect(status).to.eq(200);
        expect(body).to.have.all.keys(
          "page",
          "per_page",
          "total",
          "total_pages",
          "data",
          "support"
        );
        const { data } = body;
        for (let i = 0; i < data.length; i++) {
          expect(data[i]?.id).to.be.a("number");
          expect(data[i]?.first_name).to.not.be.empty;
          expect(data[i]?.last_name).to.not.be.empty;
          expect(data[i]?.email).to.include("@");
          expect(data[i]?.avatar).to.match(/^https/);
        }

        const { support } = body;
        expect(support.url).to.match(/^https/);
        expect(support.text).to.not.be.empty;
      }
    );
  });

[breslavsky]

Please, before my answer:

• fix message format
• fix Java Script highlighting

See as example

[AzimzadaMurad]

I made some changes, please check

[breslavsky]

Sorry, I don't see any changes.

[Vladimir-Tarasov]

Please 🙏 make review my test case and code in Cypress.

It should retrieve users

1. Get users by method GEThttps://reqres.in/api/users?page=2
2. Users should be with status 200
3. Users should have some keys
4. id should be a number
5. First name should don't be an empty
6. Last name should don't be an empty
7. Email should include symbol @
8. Avatar should be match /^https/
9. Support URL should match /^https/
10. Support text should don't be empty

Test on Cypress ~/cypress/integration/users-api.spec.js

describe('API', () => {

    it('should retrieve users', () => {

        cy.api('GET', 'https://reqres.in/api/users?page=2')
        .then(({ status, body }) => {
            expect(status).to.eq(200);
            expect(body).to.have.all.keys(
                'page',
                'per_page',
                'total',
                'total_pages',
                'data',
                'support'
            );

            const { data: users, support } = body;

            for (let user of users) {
                expect(user.id).to.be.a('number');
                expect(user.first_name).to.not.be.empty;
                expect(user.last_name).to.not.be.empty;
                expect(user.email).to.include('@');
                expect(user.avatar).to.match(/^https/);
            };

            expect(support.url).to.match(/^https/);
            expect(support.text).to.not.be.empty;
        });
    });
});

[AzimzadaMurad]

Please 🙏 make review my code in Cypress
@breslavsky

[breslavsky]

Please check my review

• use better formatting, e.g. https://beautifier.io/
• some code semantic improvements

describe('API', () => {

    it('should retrieve users', () => {

        cy.api('GET', 'https://reqres.in/api/users?page=2')
            .then(({
                status,
                body
            }) => {
                expect(status).to.eq(200);
                expect(body).to.have.all.keys(
                    'page',
                    'per_page',
                    'total',
                    'total_pages',
                    'data',
                    'support'
                );

                const {
                    support,
                    data: users
                } = body;

                expect(support.url).to.match(/^https/);
                expect(support.text).to.not.be.empty;

               // check expecting array length
               expect(users.length).to.be.eq(10);

                // user semantic in the code
                for (let user of users) {
                    expect(user.id).to.be.a('number');
                    expect(user.first_name).to.not.be.empty;
                    expect(user.last_name).to.not.be.empty;
                    expect(user.email).to.include('@');
                    expect(user.avatar).to.match(/^https/);
                };
            });
    });
});

[AzimzadaMurad]

Great job. Thank you!