Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whats the difference between the gh repo and the pip openwa package #94

Open
fire17 opened this issue Dec 6, 2021 · 2 comments
Open

Comments

@fire17
Copy link

fire17 commented Dec 6, 2021

can you please shed light on whats the difference between the repo on gh and the openwa on pip?
is there a difference? when you said you pushed changes, does that also mean that you repacked it for pip ?
or rather i should use the gh repo instead since its more updated
(sending message currently does not work for me, timeout error)
will clone the repo and try to import it manully
thx

@fire17
Copy link
Author

fire17 commented Dec 6, 2021

was able to log in with the ghrepo version AND send message
(no changes to my code besides..


fromPip = False
if fromPip:
	from openwa import WhatsAPIDriver
else:
	print("LOADING OPENWA LOCALLY")
	from openwaRepoGH.src import WhatsAPIDriver

please update the pip version (with automation perhaps)
or atleast state in the guilds that the pip version might be outdated
Thanks alot for being awesome! love you guys :)
(issue can be closed)

@darkash
Copy link
Contributor

darkash commented Dec 6, 2021

was able to log in with the ghrepo version AND send message (no changes to my code besides..


fromPip = False
if fromPip:
	from openwa import WhatsAPIDriver
else:
	print("LOADING OPENWA LOCALLY")
	from openwaRepoGH.src import WhatsAPIDriver

please update the pip version (with automation perhaps) or atleast state in the guilds that the pip version might be outdated Thanks alot for being awesome! love you guys :) (issue can be closed)

it's probably better to keep track of both since at some point earlier pip version was few version ahead of github one and now it's the reverse
As the changes in python lib on github are usually minor, this should not pose a problem, what changes often is most probable the underlying node library used, that's the one usually had changes which may or may not have impact in this library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants