Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add @asdgf/cli as dev dependency #192

Closed
wants to merge 1 commit into from

Conversation

Matsuuu
Copy link
Contributor

@Matsuuu Matsuuu commented Dec 9, 2022

Heya,

Noticed that the project uses asdgf to test the project but didn't pack it as a dev dependency at least in the analyzer. Added the package as a dev dep

@netlify
Copy link

netlify bot commented Dec 9, 2022

Deploy Preview for custom-elements-manifest-analyzer ready!

Name Link
🔨 Latest commit 9a7b25b
🔍 Latest deploy log https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/639380de7dfdc400081990e8
😎 Deploy Preview https://deploy-preview-192--custom-elements-manifest-analyzer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thepassle
Copy link
Member

Dev dependencies are hoisted in a (yarn workspaces) monorepo, so no need to install it in the package itself

@Matsuuu
Copy link
Contributor Author

Matsuuu commented Dec 9, 2022

Ah gotcha. Just noticed that too yeah.

But that means that you always have to run all of the tests for all of the packages, right?

Would it hurt to have the import also in the dev deps ofthe package itself?

@thepassle
Copy link
Member

You can run yarn from the monorepo root to install deps, and then you can cd packages/analyzer and yarn test to only run the tests for that specific package

Id prefer not to add the dep to the package specifically for consistency and to avoid different versions across the monorepo

@thepassle thepassle closed this Dec 9, 2022
@Matsuuu
Copy link
Contributor Author

Matsuuu commented Dec 9, 2022

Ah Wasn't aware you could still run the test from the package itself. Yeah let's close this one

@thepassle
Copy link
Member

Probably should add this info in a CONTRIBUTING.md as well 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants