Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update included typescript version #211

Closed
1 of 2 tasks
KingOfTac opened this issue May 15, 2023 · 3 comments
Closed
1 of 2 tasks

update included typescript version #211

KingOfTac opened this issue May 15, 2023 · 3 comments

Comments

@KingOfTac
Copy link

Checklist

  • Did you run the analyzer with the --dev flag to get more information?
  • Did you create a minimal reproduction in the playground?

Currently, it looks like the analyzer is using typescript@4.3.2 internally. AST Explorer now uses typescript@4.7.4 which has made developing plugins a bit difficult due to typescript internal interfaces changing across versions. An example of this is in the SyntaxKind enum. In AST Explorer a node kind of 237 is a VariableStatement and in the analyzer it is a WhileStatement.

@thepassle
Copy link
Member

yeah you shouldnt really check for SyntaxKind like that I dont think, you should use the methods provided by TS, like ts.isStringLiteral etc

@KingOfTac
Copy link
Author

yeah you shouldnt really check for SyntaxKind like that I dont think, you should use the methods provided by TS, like ts.isStringLiteral etc

Makes sense, thanks. One other thing I have run up against with the version bundled with the analyzer is that it looks like it doesn't associate jsDoc comments with variable declarations while newer versions of the language do.

@thepassle
Copy link
Member

Ts version was updated in 0.9.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants