Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize export kinds in markdown #87

Merged
merged 1 commit into from Jul 12, 2021
Merged

customize export kinds in markdown #87

merged 1 commit into from Jul 12, 2021

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Jul 9, 2021

What I Did

  1. Wrap Markdown name column value in backticks
  2. Separate static fields and methods from instance in markdown
  3. add exportKinds option to to-markdown and README, which lets the use replace js and custom-element-definition with strings of images by URL
  4. bump versions

@netlify
Copy link

netlify bot commented Jul 9, 2021

❌ Deploy Preview for custom-elements-manifest-analyzer failed.

🔨 Explore the source changes: 5a96a12

🔍 Inspect the deploy log: https://app.netlify.com/sites/custom-elements-manifest-analyzer/deploys/60eaf7defe1a3600077456ea

@bennypowers bennypowers force-pushed the feat/custom-kinds branch 4 times, most recently from be6954e to 057d278 Compare July 10, 2021 20:03
@bennypowers bennypowers changed the title feat(to-markdown): custom content for export kinds --readme flag, customize export kinds in markdown Jul 10, 2021
@thepassle
Copy link
Member

I think we need to communicate better. I took this to mean we're not adding md functionality to the analyzer directly, but shipping the plugin instead
image

@bennypowers
Copy link
Member Author

not adding md functionality to the analyzer directly, but shipping the plugin instead
I'd be keen to move the cli code to the plugin as well i'm just not sure how to proceed. maybe we'd have the cli entrypoint scan for plugins and augment its own args definitions?

@thepassle
Copy link
Member

maybe we'd have the cli entrypoint scan for plugins and augment its own args definitions?

This seems like a bad idea to me. If a user wants to add plugins they should use the config file

@thepassle
Copy link
Member

Not sure what to do with this PR now, it has changes that we dont really have consensus on (or had discussed to handle otherwise), has multiple changes that are not really related to eachother... Maybe we revert the --readme flag commit, find consensus on what to do with it, and move forward with the changes to to-md and cem-plugin-readme separately?

@bennypowers bennypowers marked this pull request as draft July 11, 2021 10:40
@bennypowers bennypowers changed the title --readme flag, customize export kinds in markdown customize export kinds in markdown Jul 11, 2021
@bennypowers
Copy link
Member Author

Removed the --readme flag from this PR, will open another draft to explore the idea

@bennypowers bennypowers marked this pull request as ready for review July 11, 2021 13:49
@thepassle thepassle merged commit d084439 into master Jul 12, 2021
@bennypowers bennypowers deleted the feat/custom-kinds branch July 12, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants