Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Subcribe after it is unsubscribed #121

Open
krishnastvSMSC opened this issue May 21, 2019 · 13 comments
Open

iOS - Subcribe after it is unsubscribed #121

krishnastvSMSC opened this issue May 21, 2019 · 13 comments
Labels
bug Something isn't working

Comments

@krishnastvSMSC
Copy link

Hello Team,

We subscribed one OWTRemoteStream with particular OWTConferenceSubscribeOptions. After sometime, we need to change subscription,so we stop the current subscriptions and resubscribe for the same OWTRemoteStream we got the issue as The same remote stream has already been subscribed. Subcribe after it is unsubscribed. But subscriptionDidEnd delegate is called with same subscription id. Please help us to resolve this issue.

@jianjunz jianjunz added the bug Something isn't working label May 21, 2019
@krishnastvSMSC
Copy link
Author

Hello Team,

Any update

@JamesTerm
Copy link

I'll take a guess at this, because I am working on a problem that sounds similar. For me, it is connecting peer to peer, where we connect, disconnect and reconnect (logoff, and then log back in on the browser side). The problem is that once the connection has ended the other peer needs to also disconnect to properly negotiate a new p2p session. It's easy to know how it should work from a user perspective, not so easy to understand what level the design needs to disconnect... (e.g. do I need to close the socket). What I can say is if I reset the P2PSocketSignalingChannel... it gets around the problem. I just don't know if I really need to do that, or not. Some clarification on this would be helpful.

@krishnastvSMSC
Copy link
Author

Hello JamesTerm,
In My scenario, I don't want to disconnect it. If it disconnect then over all session will close opposite person don't know our session again. And it will turn as another new call. But we need to do it in the same session.

Initially I subscribed with low resolution for thumbnail size video, after as per user selection I want to load high resolution video for this I need to re-subscribe with in the same session not in different session.

@JamesTerm
Copy link

JamesTerm commented May 23, 2019

Ah ok, thanks for clarification, perhaps I should open that as a separate issue.
I'll throw an idea out to see how it may be received. It seems fitting that a video stream client could send quality setting data back to originator then you needn't unsubscribe but rather change the quality setting dynamically. I know we'll want to address quality setting capabilities eventually to be more compatible with NDI, but if this can help you now get around this issue then it would become a dual benefit.

@KrishnaSMSC
Copy link

Thanks for replay. If we need to change the OWTConferenceSubscribeOptions we have to update or resubscribe. While doing update there is no change and the response also taking more than 10sec. Resubscribe is working fine in other platforms.

@krishnastvSMSC
Copy link
Author

Any Update will be appreciated... :-)

@jianjunz
Copy link
Collaborator

Thanks for reporting issues. It looks like there are two issues here. This code snip here might be the reason for the issue reported by krishnastvSMSC. JamesTerm's issue seems to be a bug in P2P mode.

@krishnastvSMSC
Copy link
Author

Hello jianjunz,
We are using conference client not p2p mode. We implemented as pet the link only.
First unsubscribe the existing stream, and we got callback to subscription end with same subscription id. Again we resubscribe with different video resolution, getting error as like that.

@JamesTerm
Copy link

@jianjunz I will create a separate issue for this. Thanks

@krishnastvSMSC
Copy link
Author

when we will get updated Framework for iOS with fixes of " Subcribe after it is unsubscribed. But subscriptionDidEnd delegate is called with same subscription id." issue.

@jianjunz
Copy link
Collaborator

I just tried to subscribe a stream after it is unsubscribed. But I didn't see this error. Instead, I found another issue that the video was not shown after the second subscribe call. A PR was submitted to address this issue.

@krishnastvSMSC
Copy link
Author

Hello Team,

Any update please help us to resolve it

@zhouhuirun2015
Copy link
Contributor

On windows client, I faced the same problem, wait the subscription stopped util ended() return true, or just sleep some msec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants