runtime: unexpected render

[kjk]

I might be doing something wrong but this doesn't work as I expect:

I have a macro:

{% macro licls(s1, s2 string) %}{% if s1 == s2 %}class="current"{% end %}{% end %}

I use it as:

<li {{licls(s, "home")}}>

The idea was that this renders to either nothing or to class="current".

Instead it renders as:

<li class��current�>

It looks like =" and " are garbled

Here's the repro:

func must(err error) {
	if err != nil {
		panic(err)
	}
}
func testOne() {
	navHTML := `{% macro licls(s1, s2 string) %}{% if s1 == s2 %}class='current'{% end %}{% end %}
	<li {{licls("home", "home")}}>
`
	fsys := scriggo.Files{
		"nav.html": []byte(navHTML),
	}
	template, err := scriggo.BuildTemplate(fsys, "nav.html", nil)
	must(err)
	err = template.Run(os.Stdout, nil, nil)
	must(err)
}

[gazerro]

This is the expected behavior. Simplifying your example:

{% s := "class='current'" %}
<li {{ s }}>

this code is rendered as follows

<li class��current�>

A string rendered in a tag context can only contain attribute names. It is not safe to allow other characters.

Your example could be rewritten like this

{% licls := func(s1, s2 string) bool { return s1 == s2 } %}

<li {% if licls(s, "home") %}class="current"{% end %}>

[gazerro]

Close this issue. @kjk feel free to reopen this issue if you have any questions or comments.