Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'make install' *overwrites* configuration files ?!? #252

Closed
laf0rge opened this issue Aug 15, 2019 · 4 comments
Closed

'make install' *overwrites* configuration files ?!? #252

laf0rge opened this issue Aug 15, 2019 · 4 comments

Comments

@laf0rge
Copy link
Contributor

laf0rge commented Aug 15, 2019

I've just erased all my configuration files as apparently 'make install' unconditionally overwrites any existing configuration files.

This is highly uncommon, and I don't think in 20 years working with tons of open source software built with autotools I've ever encountered another program that would overwrite user configuation files.

I think it's best to leave this to the package manager (dpkg will figure it out and prompt the user what to do). 'make install' might install only some examples to some */doc/ directory.

@acetcom
Copy link
Member

acetcom commented Aug 15, 2019

This is the part I thought long ago, and I've forgotten about it now.
Of course, I agree that make install should not overwrite this.

However, I still want to consider those who are new people in nextepc world.

One way is that nextepc daemons should have the ability to create a default configuration when they don't have a configuration file. The other way is that nextepc can be run with default parameters if there is no configuration file.

However, the freeDiameter configuration file is interfering with what I want to do.

I will consider a little bit more about how to do it.
If I can find a good solution, I will move the example configuration files to something like doc.

Thank you for reminding me this issue.

@laf0rge
Copy link
Contributor Author

laf0rge commented Aug 15, 2019

I think most programs don't copy or create any config files in the configuration directory. If you install e.g. apache from source, I don't think it creates configuration files for you. You as the user have to create them by writing from scratch or copying examples. So I don't think it is going to make nextepc mor difficult for "new people in the nextepc world".

If you want a ready-to-use system, use binary packages. If you build/install from source, I think you can also be expected to copy some text/config files.

@acetcom
Copy link
Member

acetcom commented Aug 15, 2019

It seems I've never compiled apache or nginx and installed it myself. I always install it as a package so I thought of the compile method in a similar way to the package install.

Let's first examine other open sources. If most project didn't overwrite configuration file in make install, then I'll fix it.

Much appreciated for your comment!

@acetcom
Copy link
Member

acetcom commented Oct 27, 2019

Hi @laf0rge,

To solve this problem, I used a method not to overwrite the configuration files if it is existed. I've found that the Apache web server uses it that way, and this seems not bad for new people.

BTW, the project has been renamed to Open5GS and it uses MESON build in the master branch.
You can find the release note as below link:

So, the default configuration is installed for the first time.

$ ninja -C build install

User changes the configuration files.

And then,

$ ninja -C build install

The above installation should not overwrite the configuration files.

@laf0rge laf0rge closed this as completed Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants