Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pointer targets in [...] differ in signedness [-Wpointer-sign] #27

Closed
Stasik0 opened this issue Mar 24, 2014 · 5 comments
Closed

pointer targets in [...] differ in signedness [-Wpointer-sign] #27

Stasik0 opened this issue Mar 24, 2014 · 5 comments
Labels
Type: Enhancement Describes a feature request or addition of new functionality

Comments

@Stasik0
Copy link
Contributor

Stasik0 commented Mar 24, 2014

As far as I see, the problem is that UA_Byte and char are not sign-compatible.

Does anyone have an elegant solution for that? Or should we just replace char by UA_Byte everywhere?
@jpfr
Copy link
Member

jpfr commented Mar 24, 2014

UA_SByte == char
UA_Byte == unsigned char

Why don't you use SByte when you mean char?

@FlorianPalm
Copy link
Contributor

Do we mean char? Before the encoding we do not have any type. Imho we should just replace it with UA_Byte.

@Stasik0
Copy link
Contributor Author

Stasik0 commented Mar 24, 2014

i am fine with it

@uleon
Copy link
Contributor

uleon commented Mar 24, 2014

I would vote to have UA_Byte* instead of char* for the buffers in the _encode/ _decode-functions

@uleon uleon closed this as completed in af72881 Mar 26, 2014
@lock
Copy link

lock bot commented Jul 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Enhancement Describes a feature request or addition of new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Stasik0 @jpfr @FlorianPalm @uleon