Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Check for production status #15

Closed
flowirtz opened this issue Jul 18, 2017 · 4 comments
Closed

Check for production status #15

flowirtz opened this issue Jul 18, 2017 · 4 comments
Assignees

Comments

@flowirtz
Copy link
Contributor

flowirtz commented Jul 18, 2017

When deploying to github-pages, the baseurl path is broken: "/jenz" is missing.
This can be addressed by using env vars.
NG2 does not support env vars.
Therefore, a status.ts file that holds a boolean production is used.
Upon deploy, the boolean needs to be set to true.

@flowirtz flowirtz self-assigned this Jul 18, 2017
@flowirtz
Copy link
Contributor Author

flowirtz commented Jul 18, 2017

TODO

  • Check whether this is BS: Why not use an npm env var that gets set in Travis / is undefined by default?

  • Use Travis to auto-deploy on push/merge/commit to master

@deeps96
Copy link
Contributor

deeps96 commented Jul 23, 2017

  • Repair deploy

@flowirtz
Copy link
Contributor Author

Should be "kinda fixed" with e61d86c, but also see #18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants