Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DomStringMap: Data not transmitted correctly if Array of Numbers #26

Closed
flowirtz opened this issue Jan 12, 2017 · 4 comments
Closed

DomStringMap: Data not transmitted correctly if Array of Numbers #26

flowirtz opened this issue Jan 12, 2017 · 4 comments
Assignees
Labels

Comments

@flowirtz
Copy link
Contributor

if data is supplied as array of numbers (see dataset in i.e. activityChart and pieChart), one must insert the following code into the component at the top:

<div style="display:none;">{{dataset}}</div>

If not, only a DomStringMap whill be returned on this.dataset.
This only applies to Arrays of Numbers, Arrays of Strings are not included.

WTF?!

TODO: find more elegant way to solve this. Maybe even file a bug with Polymer.

@flowirtz flowirtz added the bug label Jan 12, 2017
@flowirtz
Copy link
Contributor Author

@MaximilianV as discussed.

@flowirtz flowirtz mentioned this issue Jan 12, 2017
2 tasks
@flowirtz
Copy link
Contributor Author

@jak-ing suggested that it might be due to us using .ready instead of .attached (changed in branch activity chart afaik), worth looking into
see https://www.polymer-project.org/1.0/docs/devguide/registering-elements#lifecycle-callbacks

@flowirtz flowirtz self-assigned this Jan 24, 2017
@MaximilianV
Copy link
Contributor

did anyone tried this solution proposal?

@MaximilianV
Copy link
Contributor

tried it in #45 looks good to me for line/bar-chart and datafilter.
Changed piechart in #42 and bubblechart in #44
Please try it on your own. But I had no further issues after deleting this line.

@Langleu Langleu closed this as completed Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants