Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking events for layout changes of video player #189

Open
mathebox opened this issue Nov 12, 2019 · 0 comments
Open

Add tracking events for layout changes of video player #189

mathebox opened this issue Nov 12, 2019 · 0 comments
Labels
internal 🔨 No outward effect on the behavior. Refactorings, chores, maintenance such as updating dependencies.

Comments

@mathebox
Copy link
Member

mathebox commented Nov 12, 2019

As the video player can be presented in different layouts, we should trigger tracking events when the layout is changed, as well as adding the current layout to the context (similar to playback speed).

Proposed solution:

  • Possible values (currently supported by iOS):
    • inline
    • fullScreen
    • pictureInPicture
    • remote
  • Add current_layout to context of tracking events
  • Add new tracking VIDEO_CHANGE_LAYOUT
    • Modify context
      • Erase current_layout
      • new_layout for new layout
      • old_layout for old layout
@tobiasrohloff tobiasrohloff added the internal 🔨 No outward effect on the behavior. Refactorings, chores, maintenance such as updating dependencies. label Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal 🔨 No outward effect on the behavior. Refactorings, chores, maintenance such as updating dependencies.
Projects
None yet
Development

No branches or pull requests

2 participants