Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLAN_DIR is wrong #1284

Closed
yurivict opened this issue Apr 11, 2018 · 0 comments
Closed

FLAN_DIR is wrong #1284

yurivict opened this issue Apr 11, 2018 · 0 comments

Comments

@yurivict
Copy link

When external flann is used (-DFLANN_INCLUDE_DIR_HINTS=/usr/local/include), FindFlann.cmake sets FLANN_DIR=/usr/local/include/flann, to directory where flann.hpp is, although it is always included as #include <flann/flann.hpp>.

Also, it doesn't make sense that when user supplies the correct FLANN_INCLUDE_DIR_HINTS=/usr/local/include, the build still uses the internally computed FLANN_DIR. It should just use FLANN_INCLUDE_DIR_HINTS.

Another, a better way to handle this is to change the cmake variable to USE_EXTERNAL_FLANN=ON, and then to find it with pkg-config --cflags flann.

@pmoulon pmoulon closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants