Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid <regex> (for now) #216

Closed
ax3l opened this issue May 31, 2018 · 4 comments
Closed

Avoid <regex> (for now) #216

ax3l opened this issue May 31, 2018 · 4 comments
Assignees
Labels
internal machine/system machine & HPC system specific issues refactoring

Comments

@ax3l
Copy link
Member

ax3l commented May 31, 2018

As discussed in #210, we will try to also support GCC 4.8.

For this to work, the only thing we will need to change is the use of <regex> inside the library, as it is only implemented as a stub in GCC 4.8.

Possible alternatives are:

  • own, simple string matcher for file names
  • use another light-weight regex library, e.g. slre

For reference, this is what needs to be solved.

@ax3l ax3l added refactoring internal machine/system machine & HPC system specific issues labels May 31, 2018
@ax3l ax3l added this to To do in First Stable Release via automation May 31, 2018
This was referenced May 31, 2018
@ax3l ax3l assigned C0nsultant and unassigned C0nsultant and ax3l May 31, 2018
@ax3l
Copy link
Member Author

ax3l commented May 31, 2018

@C0nsultant if you have an idea how to implement this efficiently, feel free to say how or go ahead. I just tried to quickly hack it but needs more thinking.

@C0nsultant
Copy link
Member

You weren't far off. The only thing you didn't consider are the troubles caused by having both a prefix and a postfix.
I'll look into it.

@ax3l
Copy link
Member Author

ax3l commented May 31, 2018

Since it's a GCC 4.8 only issue, we could also use the POSIX <regex.h> header or the regex lib from glibc here as a fallback.

Resources:

@ax3l
Copy link
Member Author

ax3l commented Jun 5, 2018

Ok, I have a new draft based on the POSIX C <regex.h>

@ax3l ax3l self-assigned this Jun 5, 2018
First Stable Release automation moved this from To do to Done Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal machine/system machine & HPC system specific issues refactoring
Projects
Development

No branches or pull requests

2 participants