Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Make iteration based attributes "required" only if iteration data is stored #232

Open
DavidSagan opened this issue Oct 31, 2020 · 1 comment
Open

Proposal: Make iteration based attributes "required" only if iteration data is stored #232

DavidSagan opened this issue Oct 31, 2020 · 1 comment
Assignees
@ax3l
Labels
major change non-backwards compatible change
Projects
2.0.0
Milestone
openPMD 2.X

Comments

@DavidSagan
Copy link
Collaborator

The following iteration related attributes are marked as required:

  • iterationEncoding
  • iterationFormat
  • time
  • dt

This makes no sense unless iteration based data is being stored and therefore these attributes should only be required when storing iteration based data.
@DavidSagan DavidSagan added this to Proposed in 2.0.0 via automation Nov 4, 2020
@ax3l ax3l added this to the openPMD 2.X milestone Nov 7, 2020
@ax3l ax3l added the major change non-backwards compatible change label Nov 7, 2020
@ax3l
Copy link
Member

ax3l commented Nov 7, 2020

Thank you for the proposal.
I agree that this can simplify the standard and will incorporate it with the upcoming changes I need to do for iterationEncoding for ADIOS2.

@ax3l ax3l self-assigned this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ax3l ax3l

Labels
major change non-backwards compatible change
Projects
2.0.0
  
Proposed
Milestone
openPMD 2.X
Development

No branches or pull requests
2 participants
@DavidSagan @ax3l