-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider: Naming Slice #148
Comments
Yes, it is indeed the slice normal. Would this be a good solution? |
Wuhu, yeas that's why I thought make it short and explicit with "slice normal:" specifying the normal of the slice :) I would also rename "Coord" to "comp." or "component" since it's not necessarily along the same and can be confusing. |
OK, "Slice normal:" works. I'll prepare a PR for this. Regarding changing "coord" to "comp.", the problem is that the |
I think lets open an issue and change coord to component in a major release, e.g. 1.0.0
|
closed via #149 |
Close#148 Slider: Naming Slice
With "slice direction" in the
OpenPMDTimeSeries.slider
we actually mean the slice normal, don't we? Should we rename it, I find the term direction to be quite arbitrary in the widget (because a plane would need at least to base vectors pointing somewhere in the plane to span a slice).The text was updated successfully, but these errors were encountered: