Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish gitarro renaming #42

Closed
2 tasks done
MalloZup opened this issue Sep 27, 2017 · 6 comments
Closed
2 tasks done

finish gitarro renaming #42

MalloZup opened this issue Sep 27, 2017 · 6 comments

Comments

@MalloZup
Copy link
Contributor

MalloZup commented Sep 27, 2017

  • rename docker images related stuff.

  • Rename all Jenkins jobs to use gitarro (done partially)

@juliogonzalez
Copy link
Member

Yes, and at the same time the way of calling the bot should be configurable (and by default the new name).

Right now it's confusing since @gitbot is a mention to a user called gitbot at GitHub, and even more confuse when the users that people use to run gitbot could be different :-D

However keep in mind that when we change the name we will need to:

  • Correct the Docker Hub project name.
  • Correct all the doc inside this repo and outside (Docker Hub).

@juliogonzalez
Copy link
Member

juliogonzalez commented Sep 27, 2017

Some other (boring) names:

  • git-o-check (gitocheck)
  • git-o-matic (gitomatic)
  • git-o-tester (gitotester)

And one 'Spanish':

But I also like gitarro a lot (and it should be easy to make a logo) :-D

@juliogonzalez
Copy link
Member

juliogonzalez commented Sep 28, 2017

It is easy to pronounce in most languages, it is funny, it is easy to remember, it should be easy to make a logo, and (as you say) it is easy to write on cmdline.

+1 for guitarro :-D

Video:
IMAGE ALT TEXT

@MalloZup MalloZup changed the title gitbot need a new name finish gitarro renaming Sep 28, 2017
@MalloZup MalloZup mentioned this issue Sep 28, 2017
@juliogonzalez
Copy link
Member

Regarding Jenkins Jobs: I think right now they use a gitbot.rb outside the workspace.

I propose making gitarro stable tomorrow, and make a release on monday.

Then we will instruct Jenkins Jobs not using Docker to clone gitarro from the repo each time they run, using the release tag.

And for the jobs using Docker, I will change the Dockerfile to fetch the latest stable available (right now it downloads the last commit available at master), and will rename the images.

Let's discuss it tomorrow.

@juliogonzalez
Copy link
Member

Oh, before the release we should consider merging the --change_newer option and the other one to fetch only the commits we need for the tests, instead of the whole repo. Will help a lot with the big repo we have.

@juliogonzalez
Copy link
Member

This can now be closed: https://hub.docker.com/r/gitarro/rubocop/tags/ (tested at: https://jenkins.juliogonzalez.es/job/cdtraining-gitbot-test-pr/5/console)

@MalloZup MalloZup closed this as completed Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants