Add support for non-installable packages in whatmatchessolvable()

[ignatenkobrain]

#!/usr/bin/python3

import solv

pool = solv.Pool()

repo = pool.add_repo('available')
sprov = repo.add_solvable()
sprov.name = 'sprov'
sprov.evr = '1-1'
sprov.arch = 'noarch'
sprov.add_deparray(solv.SOLVABLE_PROVIDES, pool.Dep('x').Rel(solv.REL_EQ, pool.str2id('2.1.0')))
for arch in ('noarch', 'src'):
    sreq = repo.add_solvable()
    sreq.name = f's-{arch}'
    sreq.evr = '1-1'
    sreq.arch = arch
    sreq.add_deparray(solv.SOLVABLE_REQUIRES, pool.parserpmrichdep('(x >= 2.0.0 with x < 3.0.0)'))

pool.createwhatprovides()

print(pool.whatmatchessolvable(solv.SOLVABLE_REQUIRES, sprov))

returns

[<Solvable #3 s-noarch-1-1.noarch>]

[ignatenkobrain]

/* intersect dependencies in keyname with all provides of solvable solvid,                                    
 * return list of matching packages */                                                                        
/* this currently only works for installable packages */                                                      

which does check for pool_installable(), which mean packages with ARCH_SRC are ignored...

[ignatenkobrain]

@mlschroe what would it take to add support of non-installable packages to this function?

[mlschroe]

I don't think we should for consistency reasons. Why don't you use the selection variant as a workaround?

sel = pool.Selection_all()
sel.matchsolvable(sprov, 0, solv.SOLVABLE_REQUIRES)
print(sel.solvables())

[mlschroe]

(Too bad that swig prevents a return of $self so that we could write pool.Selection_all().matchsolvable(...).solvables())

[ignatenkobrain]

Oh, I didn't know about this workaround :)

[ignatenkobrain]

Too bad that swig prevents a return of $self

Can't you return XSelection and tell it to not free memory on it?

[mlschroe]

No, that wouldn't work. sel = sel.matchsolvable() would free the underlying object. It needs to be some SWIG trickery.

[mlschroe]

Hey, I found out how to do it. See commit 6935152