/
source_controller_test.rb
2714 lines (2390 loc) · 112 KB
/
source_controller_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# encoding: UTF-8
require File.expand_path(File.dirname(__FILE__) + "/..") + "/test_helper"
require 'source_controller'
class SourceControllerTest < ActionController::IntegrationTest
fixtures :all
def test_get_projectlist
prepare_request_with_user "tom", "thunder"
get "/source"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :only => { :tag => "entry" } }
end
def test_get_projectlist_with_hidden_project
prepare_request_with_user "tom", "thunder"
get "/source"
assert_response :success
assert_no_match(/entry name="HiddenProject"/, @response.body)
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source"
assert_response :success
assert_match(/entry name="HiddenProject"/, @response.body)
end
def test_get_projectlist_with_sourceaccess_protected_project
prepare_request_with_user "tom", "thunder"
get "/source"
assert_response :success
assert_match(/entry name="SourceprotectedProject"/, @response.body)
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source"
assert_response :success
assert_match(/entry name="SourceprotectedProject"/, @response.body)
end
def test_get_packagelist
prepare_request_with_user "tom", "thunder"
get "/source/kde4"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 2, :only => { :tag => "entry" } }
end
def test_get_packagelist_with_hidden_project
prepare_request_with_user "tom", "thunder"
get "/source/HiddenProject"
assert_response 404
assert_match(/not_found/, @response.body)
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source/HiddenProject"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 3, :only => { :tag => "entry" } }
assert_match(/entry name="pack"/, @response.body)
assert_match(/entry name="target"/, @response.body)
end
def test_get_packagelist_with_sourceprotected_project
prepare_request_with_user "tom", "thunder"
get "/source/SourceprotectedProject"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 2 }
assert_match(/entry name="target"/, @response.body)
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source/SourceprotectedProject"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 2, :only => { :tag => "entry" } }
assert_match(/entry name="pack"/, @response.body)
assert_match(/entry name="target"/, @response.body)
end
# non-existing project should return 404
def test_get_illegal_project
prepare_request_with_user "tom", "thunder"
get "/source/kde2000/_meta"
assert_response 404
end
# non-existing project-package should return 404
def test_get_illegal_projectfile
prepare_request_with_user "tom", "thunder"
get "/source/kde4/kdelibs2000/_meta"
assert_response 404
end
def test_use_illegal_encoded_parameters
prepare_request_with_user "king", "sunflower"
raw_put "/source/kde4/kdelibs/DUMMY?comment=working%20with%20Uml%C3%A4ut", "WORKING"
assert_response :success
raw_put "/source/kde4/kdelibs/DUMMY?comment=illegalchar%96%96asd", "NOTWORKING"
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "invalid_text_encoding" }
end
def test_get_project_meta
prepare_request_with_user "tom", "thunder"
get "/source/kde4/_meta"
assert_response :success
assert_xml_tag :tag => "project", :attributes => { :name => "kde4" }
end
def test_get_project_meta_from_hidden_project
prepare_request_with_user "tom", "thunder"
get "/source/HiddenProject/_meta"
assert_response 404
assert_match(/unknown_project/, @response.body)
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source/HiddenProject/_meta"
assert_response :success
assert_xml_tag :tag => "project", :attributes => { :name => "HiddenProject" }
end
def test_get_project_meta_from_sourceaccess_protected_project
prepare_request_with_user "tom", "thunder"
get "/source/SourceprotectedProject/_meta"
assert_response :success
assert_xml_tag :tag => "project", :attributes => { :name => "SourceprotectedProject" }
#retry with maintainer
reset_auth
prepare_request_with_user "sourceaccess_homer", "homer"
get "/source/SourceprotectedProject/_meta"
assert_response :success
assert_xml_tag :tag => "project", :attributes => { :name => "SourceprotectedProject" }
end
def test_get_package_filelist
prepare_request_with_user "tom", "thunder"
get "/source/kde4/kdelibs"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 1, :only => { :tag => "entry", :attributes => { :name => "my_patch.diff" } } }
# now testing if also others can see it
prepare_request_with_user "Iggy", "asdfasdf"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 1, :only => { :tag => "entry", :attributes => { :name => "my_patch.diff" } } }
end
def test_get_package_filelist_from_hidden_project
prepare_request_with_user "tom", "thunder"
get "/source/HiddenProject/pack"
assert_response 404
assert_xml_tag :tag => "status", :attributes => { :code => "unknown_project" }
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source/HiddenProject/pack"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 2 }
end
def test_get_package_filelist_from_sourceaccess_protected_project
prepare_request_with_user "tom", "thunder"
get "/source/SourceprotectedProject/pack"
assert_response 403
#retry with maintainer
reset_auth
prepare_request_with_user "sourceaccess_homer", "homer"
get "/source/SourceprotectedProject/pack"
assert_response :success
assert_xml_tag :tag => "directory", :child => { :tag => "entry" }
assert_xml_tag :tag => "directory",
:children => { :count => 2 }
end
def test_get_package_meta
prepare_request_with_user "tom", "thunder"
get "/source/kde4/kdelibs/_meta"
assert_response :success
assert_xml_tag :tag => "package", :attributes => { :name => "kdelibs" }
end
def test_get_package_meta_from_hidden_project
prepare_request_with_user "tom", "thunder"
get "/source/HiddenProject/pack/_meta"
assert_response 404
assert_xml_tag :tag => "status", :attributes => { :code => "unknown_project" }
#retry with maintainer
reset_auth
prepare_request_with_user "adrian", "so_alone"
get "/source/HiddenProject/pack/_meta"
assert_response :success
assert_xml_tag :tag => "package", :attributes => { :name => "pack" , :project => "HiddenProject"}
end
def test_get_package_meta_from_sourceacces_protected_project
# package meta is visible
prepare_request_with_user "tom", "thunder"
get "/source/SourceprotectedProject/pack/_meta"
assert_response :success
assert_xml_tag :tag => "package", :attributes => { :name => "pack" , :project => "SourceprotectedProject"}
# retry with maintainer
reset_auth
prepare_request_with_user "sourceaccess_homer", "homer"
get "/source/SourceprotectedProject/pack/_meta"
assert_response :success
assert_xml_tag :tag => "package", :attributes => { :name => "pack" , :project => "SourceprotectedProject"}
end
def test_invalid_project_and_package_name
prepare_request_with_user "king", "sunflower"
[ "_blah" ].each do |n|
raw_put url_for(:controller => :source, :action => :project_meta, :project => n), "<project name='#{n}'> <title /> <description /> </project>"
assert_response 400
put "/source/kde4/#{n}/_meta", "<package project='kde4' name='#{n}'> <title /> <description /> </project>"
assert_response 400
post "/source/kde4/kdebase", :cmd => "branch", :target_package => n
assert_response 400
post "/source/kde4/#{n}", :cmd => "copy", :opackage => "kdebase", :oproject => "kde4"
if n == ".."
# this is failing already at routing
assert_response 403
else
assert_response 400
end
end
end
test "can branch package under two names" do
prepare_request_with_user "king", "sunflower"
post "/source/home:Iggy/TestPack", :cmd => "branch", :target_package => "TestPack2"
assert_response :success
# this is behaving strange as it's creating a TestPack3 pack, but returns a 400
# as it tries to branch TestPack2 -> TestPack too and fails
if $ENABLE_BROKEN_TEST
post "/source/home:Iggy/TestPack", :cmd => "branch", :target_package => "TestPack3"
assert_response :success
end
end
# project_meta does not require auth
def test_invalid_user
prepare_request_with_user "king123", "sunflower"
get "/source/kde4/_meta"
assert_response 401
end
def test_valid_user
prepare_request_with_user "tom", "thunder"
get "/source/kde4/_meta"
assert_response :success
end
def test_put_project_meta_with_invalid_permissions
prepare_request_with_user "tom", "thunder"
# The user is valid, but has weak permissions
# Get meta file
get "/source/kde4/_meta"
assert_response :success
# Change description
xml = @response.body
new_desc = "Changed description"
doc = REXML::Document.new( xml )
d = doc.elements["//description"]
d.text = new_desc
# Write changed data back
put url_for(:controller => :source, :action => :project_meta, :project => "kde4"), doc.to_s
assert_response 403
# admin only tag
d = doc.elements["/project"]
d = d.add_element "remoteurl"
d.text = "http://localhost:5352"
prepare_request_with_user "fred", "geröllheimer"
put url_for(:controller => :source, :action => :project_meta, :project => "kde4"), doc.to_s
assert_response 403
assert_match(/admin rights are required to change remoteurl/, @response.body)
# invalid xml
raw_put url_for(:controller => :source, :action => :project_meta, :project => "NewProject"), "<asd/>"
assert_response 400
assert_match(/validation error/, @response.body)
# new project
raw_put url_for(:controller => :source, :action => :project_meta, :project => "NewProject"), "<project name='NewProject'><title>blub</title><description/></project>"
assert_response 403
assert_match(/not allowed to create new project/, @response.body)
prepare_request_with_user "king", "sunflower"
raw_put url_for(:controller => :source, :action => :project_meta, :project => "_NewProject"), "<project name='_NewProject'><title>blub</title><description/></project>"
assert_response 400
assert_match(/Name is illegal/, @response.body)
end
def test_put_project_meta
prj="kde4" # project
resp1=:success # expected response 1 & 2
resp2=:success # \/ expected assert
aresp={:tag => "status", :attributes => { :code => "ok" } }
match=true # value written matches 2nd read
# admin
prepare_request_with_user "king", "sunflower"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# maintainer
prepare_request_with_user "fred", "geröllheimer"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# maintainer via group
prepare_request_with_user "adrian", "so_alone"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# check history
get "/source/kde4/_project/_history?meta=1"
assert_response :success
assert_xml_tag( :tag => "revisionlist" )
assert_xml_tag( :tag => "user", :content => "adrian" )
end
def test_create_subproject
subprojectmeta="<project name='kde4:subproject'><title></title><description/></project>"
# nobody
reset_auth
put url_for(:controller => :source, :action => :project_meta, :project => "kde4:subproject"), subprojectmeta
assert_response 401
prepare_request_with_user "tom", "thunder"
put url_for(:controller => :source, :action => :project_meta, :project => "kde4:subproject"), subprojectmeta
assert_response 403
# admin
prepare_request_with_user "king", "sunflower"
put url_for(:controller => :source, :action => :project_meta, :project => "kde4:subproject"), subprojectmeta
assert_response :success
delete "/source/kde4:subproject"
assert_response :success
# maintainer
prepare_request_with_user "fred", "geröllheimer"
put url_for(:controller => :source, :action => :project_meta, :project => "kde4:subproject"), subprojectmeta
assert_response :success
delete "/source/kde4:subproject"
assert_response :success
# maintainer via group
prepare_request_with_user "adrian", "so_alone"
put url_for(:controller => :source, :action => :project_meta, :project => "kde4:subproject"), subprojectmeta
assert_response :success
delete "/source/kde4:subproject"
assert_response :success
# create illegal project
prepare_request_with_user "fred", "geröllheimer"
subprojectmeta="<project name='kde4_subproject'><title></title><description/></project>"
put url_for(:controller => :source, :action => :project_meta, :project => "kde4:subproject"), subprojectmeta
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "project_name_mismatch" }
end
def test_put_project_meta_hidden_project
prj="HiddenProject"
# uninvolved user
resp1=404
resp2=nil
aresp=nil
match=nil
prepare_request_with_user "tom", "thunder"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# admin
resp1=:success
resp2=:success
aresp={:tag => "status", :attributes => { :code => "ok" } }
match=true
prepare_request_with_user "king", "sunflower"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# maintainer
prepare_request_with_user "hidden_homer", "homer"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# FIXME: maintainer via group
end
def test_put_project_meta_sourceaccess_protected_project
prj="SourceprotectedProject"
# uninvolved user - can't change meta
resp1=:success
resp2=403
aresp={:tag => "status", :attributes => { :code => "change_project_no_permission" } }
match=nil
prepare_request_with_user "tom", "thunder"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# same with set_flag command ?
post "/source/SourceprotectedProject?cmd=set_flag&flag=sourceaccess&status=enable"
assert_response 403
assert_match(/no permission to execute command/, @response.body)
# admin
resp1=:success
resp2=:success
aresp={:tag => "status", :attributes => { :code => "ok" } }
match=true
prepare_request_with_user "king", "sunflower"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
# maintainer
prepare_request_with_user "sourceaccess_homer", "homer"
do_change_project_meta_test(prj, resp1, resp2, aresp, match)
end
def do_change_project_meta_test (project, response1, response2, tag2, doesmatch)
# Get meta file
get url_for(:controller => :source, :action => :project_meta, :project => project)
assert_response response1
if !( response2 && tag2 )
#dummy write to check blocking
put url_for(:controller => :source, :action => :project_meta, :project => project), "<project name=\"#{project}\"><title></title><description></description></project>"
assert_response 403 #4
# assert_match(/unknown_project/, @response.body)
assert_match(/create_project_no_permission/, @response.body)
return
end
# Change description
xml = @response.body
new_desc = "Changed description"
doc = REXML::Document.new( xml )
d = doc.elements["//description"]
d.text = new_desc
# Write changed data back
put url_for(:controller => :source, :action => :project_meta, :project => project), doc.to_s
assert_response response2
assert_xml_tag(tag2)
# Get data again and check that it is the changed data
get url_for(:controller => :source, :action => :project_meta, :project => project)
assert_response :success
assert_equal new_desc, Xmlhash.parse(@response.body)["description"] if doesmatch
end
private :do_change_project_meta_test
def test_create_and_delete_project
prepare_request_with_user("king", "sunflower")
# Get meta file
get url_for(:controller => :source, :action => :project_meta, :project => "kde4")
assert_response :success
xml = @response.body
doc = REXML::Document.new( xml )
# change name to kde5:
d = doc.elements["/project"]
d.delete_attribute( 'name' )
d.add_attribute( 'name', 'kde5' )
put url_for(:controller => :source, :action => :project_meta, :project => "kde5"), doc.to_s
assert_response(:success, "--> king was not allowed to create a project")
assert_xml_tag( :tag => "status", :attributes => { :code => "ok" })
# Get data again and check that the maintainer was added
get url_for(:controller => :source, :action => :project_meta, :project => "kde5")
assert_response :success
assert_select "project[name=kde5]"
assert_select "person[userid=king][role=maintainer]", {}, "Creator was not added as project maintainer"
prepare_request_with_user "maintenance_coord", "power"
delete "/source/kde5"
assert_response 403
prepare_request_with_user "fred", "geröllheimer"
delete "/source/kde5"
assert_response :success
end
def test_put_invalid_project_meta
prepare_request_with_user "fred", "geröllheimer"
# Get meta file
get url_for(:controller => :source, :action => :project_meta, :project => "kde4")
assert_response :success
xml = @response.body
olddoc = REXML::Document.new( xml )
doc = REXML::Document.new( xml )
# Write corrupt data back
put url_for(:controller => :source, :action => :project_meta, :project => "kde4"), doc.to_s + "</xml>"
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "validation_failed" }
prepare_request_with_user "king", "sunflower"
# write to illegal location:
put url_for(:controller => :source, :action => :project_meta, :project => "$hash"), doc.to_s
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "invalid_project_name" }
#must not create a project with different pathname and name in _meta.xml:
put url_for(:controller => :source, :action => :project_meta, :project => "kde5"), doc.to_s
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "project_name_mismatch" }
#TODO: referenced repository names must exist
#verify data is unchanged:
get url_for(:controller => :source, :action => :project_meta, :project => "kde4" )
assert_response :success
assert_equal( olddoc.to_s, REXML::Document.new( ( @response.body )).to_s)
end
def test_lock_project
prepare_request_with_user "Iggy", "asdfasdf"
put "/source/home:Iggy/TestLinkPack/_meta", "<package project='home:Iggy' name='TestLinkPack'> <title/> <description/> </package>"
assert_response :success
put "/source/home:Iggy/TestLinkPack/_link", "<link package='TestPack' />"
assert_response :success
# lock project
get "/source/home:Iggy/_meta"
assert_response :success
doc = REXML::Document.new( @response.body )
doc.elements["/project"].add_element "lock"
doc.elements["/project/lock"].add_element "enable"
put "/source/home:Iggy/_meta", doc.to_s
assert_response :success
get "/source/home:Iggy/_meta"
assert_response :success
assert_xml_tag :parent => { :tag => "project" }, :tag => "lock"
assert_xml_tag :parent => { :tag => "lock" }, :tag => "enable"
# modifications are not allowed anymore
delete "/source/home:Iggy"
assert_response 403
delete "/source/home:Iggy/TestLinkPack"
assert_response 403
doc.elements["/project/description"].text = "new text"
put "/source/home:Iggy/_meta", doc.to_s
assert_response 403
put "/source/home:Iggy/TestLinkPack/_link", ""
assert_response 403
# check branching from a locked project
post "/source/home:Iggy/TestLinkPack", :cmd => "branch"
assert_response :success
get "/source/home:Iggy:branches:home:Iggy/_meta"
assert_response :success
assert_no_xml_tag :tag => 'lock'
# try to unlock without comment
post "/source/home:Iggy", { :cmd => "unlock" }
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "no_comment" }
# unlock does not work via meta data anymore
doc.elements["/project/lock"].delete_element "enable"
doc.elements["/project/lock"].add_element "disable"
put "/source/home:Iggy/_meta", doc.to_s
assert_response 403
# check unlock command
prepare_request_with_user "adrian", "so_alone"
post "/source/home:Iggy", { :cmd => "unlock", :comment => "cleanup" }
assert_response 403
prepare_request_with_user "Iggy", "asdfasdf"
post "/source/home:Iggy", { :cmd => "unlock", :comment => "cleanup" }
assert_response :success
# cleanup works now again
delete "/source/home:Iggy/TestLinkPack"
assert_response :success
delete "/source/home:Iggy:branches:home:Iggy"
assert_response :success
end
def test_lock_package
prepare_request_with_user "Iggy", "asdfasdf"
put "/source/home:Iggy/TestLinkPack/_meta", "<package project='home:Iggy' name='TestLinkPack'> <title/> <description/> </package>"
assert_response :success
# lock package
get "/source/home:Iggy/TestLinkPack/_meta"
assert_response :success
doc = REXML::Document.new( @response.body )
doc.elements["/package"].add_element "lock"
doc.elements["/package/lock"].add_element "enable"
put "/source/home:Iggy/TestLinkPack/_meta", doc.to_s
assert_response :success
get "/source/home:Iggy/TestLinkPack/_meta"
assert_response :success
assert_xml_tag :parent => { :tag => "package" }, :tag => "lock"
assert_xml_tag :parent => { :tag => "lock" }, :tag => "enable"
# modifications are not allowed anymore
delete "/source/home:Iggy/TestLinkPack"
assert_response 403
doc.elements["/package/description"].text = "new text"
put "/source/home:Iggy/TestLinkPack/_meta", doc.to_s
assert_response 403
put "/source/home:Iggy/TestLinkPack/_link", ""
assert_response 403
# make package read-writable is not working via meta
doc.elements["/package/lock"].delete_element "enable"
doc.elements["/package/lock"].add_element "disable"
put "/source/home:Iggy/TestLinkPack/_meta", doc.to_s
assert_response 403
# try to unlock without comment
post "/source/home:Iggy/TestLinkPack", { :cmd => "unlock" }
assert_response 400
assert_xml_tag :tag => "status", :attributes => { :code => "no_comment" }
# without permissions
prepare_request_with_user "adrian", "so_alone"
post "/source/home:Iggy/TestLinkPack", { :cmd => "unlock", :comment => "BlahFasel" }
assert_response 403
# do for real and cleanup
prepare_request_with_user "Iggy", "asdfasdf"
post "/source/home:Iggy/TestLinkPack", { :cmd => "unlock", :comment => "BlahFasel" }
assert_response :success
delete "/source/home:Iggy/TestLinkPack"
assert_response :success
end
def test_put_package_meta_with_invalid_permissions
prepare_request_with_user "tom", "thunder"
# The user is valid, but has weak permissions
get url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs")
assert_response :success
# Change description
xml = @response.body
new_desc = "Changed description"
olddoc = REXML::Document.new( xml )
doc = REXML::Document.new( xml )
d = doc.elements["//description"]
d.text = new_desc
# Write changed data back
put url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs"), doc.to_s
assert_response 403
#verify data is unchanged:
get url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs")
assert_response :success
assert_equal( olddoc.to_s, REXML::Document.new(( @response.body )).to_s)
# try to trick api via non matching xml attributes
doc.root.attributes["project"] = "kde4"
put url_for(:controller => :source, :action => :package_meta, :project => "home:tom", :package => "kdelibs"), doc.to_s
assert_response 400
assert_xml_tag( :tag => "status", :attributes => { :code => "project_name_mismatch"} )
doc.root.attributes["project"] = nil
doc.root.attributes["name"] = "none"
put url_for(:controller => :source, :action => :package_meta, :project => "home:tom", :package => "kdelibs"), doc.to_s
assert_response 400
assert_xml_tag( :tag => "status", :attributes => { :code => "package_name_mismatch"} )
end
def test_put_package_meta_to_hidden_pkg_invalid_permissions
prepare_request_with_user "tom", "thunder"
# The user is valid, but has weak permissions
get url_for(:controller => :source, :action => :package_meta, :project => "HiddenProject", :package => "pack")
assert_response 404
# Write changed data back
put url_for(:controller => :source, :action => :package_meta, :project => "HiddenProject", :package => "pack"), "<package name=\"pack\"><title></title><description></description></package>"
assert_response 404
end
def do_change_package_meta_test (project, package, response1, response2, tag2, match)
# Get meta file
get url_for(:controller => :source, :action => :package_meta, :project => project, :package => package)
assert_response response1
if !( response2 && tag2 )
#dummy write to check blocking
put url_for(:controller => :source, :action => :package_meta, :project => project, :package => package), "<package><title></title><description></description></package>"
assert_response 404
# assert_match(/unknown_package/, @response.body)
assert_match(/unknown_project/, @response.body)
return
end
# Change description
xml = @response.body
new_desc = "Changed description"
doc = REXML::Document.new( xml )
d = doc.elements["//description"]
d.text = new_desc
# Write changed data back
put url_for(:controller => :source, :action => :package_meta, :project => project, :package => package), doc.to_s
assert_response response2 #(:success, "--> Was not able to update kdelibs _meta")
assert_xml_tag tag2 #( :tag => "status", :attributes => { :code => "ok"} )
# Get data again and check that it is the changed data
get url_for(:controller => :source, :action => :package_meta, :project => project, :package => package)
newdoc = REXML::Document.new( @response.body )
d = newdoc.elements["//description"]
#ignore updated change
newdoc.root.attributes['updated'] = doc.root.attributes['updated']
assert_equal new_desc, d.text if match
assert_equal doc.to_s, newdoc.to_s if match
end
private :do_change_package_meta_test
# admins, project-maintainer and package maintainer can edit package data
def test_put_package_meta
prj="kde4"
pkg="kdelibs"
resp1=:success
resp2=:success
aresp={:tag => "status", :attributes => { :code => "ok"} }
match=true
# admin
prepare_request_with_user "king", "sunflower"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# maintainer via user
prepare_request_with_user "fred", "geröllheimer"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
prepare_request_with_user "fredlibs", "geröllheimer"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# maintainer via group
prepare_request_with_user "adrian", "so_alone"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# check history
get "/source/kde4/kdelibs/_history?meta=1"
assert_response :success
assert_xml_tag( :tag => "revisionlist" )
assert_xml_tag( :tag => "user", :content => "adrian" )
end
def test_put_package_meta_hidden_package
prj="HiddenProject"
pkg="pack"
resp1=404
resp2=nil
aresp=nil
match=false
# uninvolved user
prepare_request_with_user "fred", "geröllheimer"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# admin
resp1=:success
resp2=:success
aresp={:tag => "status", :attributes => { :code => "ok"} }
match=true
prepare_request_with_user "king", "sunflower"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# maintainer
prepare_request_with_user "hidden_homer", "homer"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
end
def test_put_package_meta_sourceaccess_protected_package
prj="SourceprotectedProject"
pkg="pack"
resp1=:success
resp2=403
aresp={:tag => "status", :attributes => { :code => "change_package_no_permission" } }
match=nil
# uninvolved user
prepare_request_with_user "fred", "geröllheimer"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# admin
resp1=:success
resp2=:success
aresp={:tag => "status", :attributes => { :code => "ok"} }
match=true
prepare_request_with_user "king", "sunflower"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
# maintainer
prepare_request_with_user "sourceaccess_homer", "homer"
do_change_package_meta_test(prj,pkg,resp1,resp2,aresp,match)
end
def test_create_package_meta
# user without any special roles
prepare_request_with_user "fred", "geröllheimer"
get url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs")
assert_response :success
#change name to kdelibs2
xml = @response.body
doc = REXML::Document.new( xml )
d = doc.elements["/package"]
d.delete_attribute( 'name' )
d.add_attribute( 'name', 'kdelibs2' )
put url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs2"), doc.to_s
assert_response :success
assert_xml_tag( :tag => "status", :attributes => { :code => "ok"} )
# do not allow to create it with invalid name
put url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs3"), doc.to_s
assert_response 400
# Get data again and check that the maintainer was added
get url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs2")
assert_response :success
newdoc = REXML::Document.new( @response.body )
d = newdoc.elements["/package"]
assert_equal(d.attribute('name').value(), 'kdelibs2', "Project name was not set to kdelibs2")
# check for lacking permission to create a package
prepare_request_with_user "tom", "thunder"
d.delete_attribute( 'name' )
d.add_attribute( 'name', 'kdelibs3' )
put url_for(:controller => :source, :action => :package_meta, :project => "kde4", :package => "kdelibs3"), newdoc.to_s
assert_response 403
assert_xml_tag( :tag => "status", :attributes => { :code => "create_package_no_permission"} )
end
def test_captial_letter_change
prepare_request_with_user "tom", "thunder"
put "/source/home:tom:projectA/_meta", "<project name='home:tom:projectA'> <title/> <description/> <repository name='repoA'/> </project>"
assert_response :success
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='home:tom:projectA' repository='repoA' /> </repository> </project>"
assert_response :success
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_xml_tag :tag => "path", :attributes => { :project => 'home:tom:projectA' }
assert_no_xml_tag :tag => "path", :attributes => { :project => 'home:tom:projecta' }
# write again with a capital letter change
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='home:tom:projecta' repository='repoA' /> </repository> </project>"
assert_response 404
assert_xml_tag :tag => "status", :attributes => { :code => 'unknown_project' }
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_xml_tag :tag => "path", :attributes => { :project => 'home:tom:projectA' }
assert_no_xml_tag :tag => "path", :attributes => { :project => 'home:tom:projecta' }
# change back using remote project
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='RemoteInstance:home:tom:projectA' repository='repoA' /> </repository> </project>"
assert_response :success
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_xml_tag :tag => "path", :attributes => { :project => 'RemoteInstance:home:tom:projectA' }
assert_no_xml_tag :tag => "path", :attributes => { :project => 'RemoteInstance:home:tom:projecta' }
if $ENABLE_BROKEN_TEST
# FIXME: the case insensitive database select is not okay.
# and switch letter again
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='RemoteInstance:home:tom:projecta' repository='repoA' /> </repository> </project>"
assert_response 404
assert_xml_tag :tag => "status", :attributes => { :code => 'unknown_project' }
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_xml_tag :tag => "path", :attributes => { :project => 'RemoteInstance:home:tom:projectA' }
assert_no_xml_tag :tag => "path", :attributes => { :project => 'RemoteInstance:home:tom:projecta' }
end
# cleanup
delete "/source/home:tom:projectB"
assert_response :success
delete "/source/home:tom:projectA"
assert_response :success
end
def test_repository_dependencies
prepare_request_with_user "tom", "thunder"
put "/source/home:tom:projectA/_meta", "<project name='home:tom:projectA'> <title/> <description/> <repository name='repoA'/> </project>"
assert_response :success
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='home:tom:projectA' repository='repoA' /> </repository> </project>"
assert_response :success
put "/source/home:tom:projectC/_meta", "<project name='home:tom:projectC'> <title/> <description/> <repository name='repoC'> <path project='home:tom:projectB' repository='repoB' /> </repository> </project>"
assert_response :success
put "/source/home:tom:projectD/_meta", "<project name='home:tom:projectD'> <title/> <description/> <repository name='repoD'> " \
" <path project='home:tom:projectA' repository='repoA' />" \
" <path project='home:tom:projectB' repository='repoB' />" \
" <path project='home:tom:projectC' repository='repoC' />" \
"</repository> </project>"
assert_response :success
# delete a repo
put "/source/home:tom:projectA/_meta", "<project name='home:tom:projectA'> <title/> <description/> </project>"
assert_response 400
assert_xml_tag( :tag => "status", :attributes => { :code => "repo_dependency"} )
delete "/source/home:tom:projectA"
assert_response 403
put "/source/home:tom:projectA/_meta?force=1", "<project name='home:tom:projectA'> <title/> <description/> </project>"
assert_response :success
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_xml_tag :tag => 'path', :attributes => { :project => "deleted", :repository => "deleted" }
get "/source/home:tom:projectC/_meta"
assert_response :success
assert_xml_tag :tag => 'path', :attributes => { :project => "home:tom:projectB", :repository => "repoB" } # unmodified
# delete another repo
put "/source/home:tom:projectB/_meta?force=1", "<project name='home:tom:projectB'> <title/> <description/> </project>"
assert_response :success
get "/source/home:tom:projectD/_meta"
assert_response :success
assert_xml_tag :tag => 'path', :attributes => { :project => "deleted", :repository => "deleted" }
assert_xml_tag :tag => 'path', :attributes => { :project => "home:tom:projectC", :repository => "repoC" } # unmodified
# cleanup
delete "/source/home:tom:projectA"
assert_response :success
delete "/source/home:tom:projectB"
assert_response :success
delete "/source/home:tom:projectC"
assert_response 403 # projectD is still using it
delete "/source/home:tom:projectD"
assert_response :success
delete "/source/home:tom:projectC"
assert_response :success
end
def test_full_remove_repository_dependencies
prepare_request_with_user "tom", "thunder"
put "/source/home:tom:projectA/_meta", "<project name='home:tom:projectA'> <title/> <description/> <repository name='repoA'/> </project>"
assert_response :success
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='home:tom:projectA' repository='repoA' /> </repository> </project>"
assert_response :success
put "/source/home:tom:projectC/_meta", "<project name='home:tom:projectC'> <title/> <description/> <repository name='repoC'> <path project='home:tom:projectB' repository='repoB' /> </repository> </project>"
assert_response :success
# delete a repo
put "/source/home:tom:projectA/_meta", "<project name='home:tom:projectA'> <title/> <description/> </project>"
assert_response 400
assert_xml_tag( :tag => "status", :attributes => { :code => "repo_dependency"} )
delete "/source/home:tom:projectA"
assert_response 403
put "/source/home:tom:projectA/_meta?force=1&remove_linking_repositories=1", "<project name='home:tom:projectA'> <title/> <description/> </project>"
assert_response :success
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_no_xml_tag :tag => 'path'
get "/source/home:tom:projectC/_meta"
assert_response :success
assert_no_xml_tag :tag => 'path'
# cleanup
delete "/source/home:tom:projectA"
assert_response :success
delete "/source/home:tom:projectB"
assert_response :success
delete "/source/home:tom:projectC"
assert_response :success
end
def test_delete_project_with_repository_dependencies
prepare_request_with_user "tom", "thunder"
put "/source/home:tom:projectA/_meta", "<project name='home:tom:projectA'> <title/> <description/> <repository name='repoA'> <arch>i586</arch> </repository> </project>"
assert_response :success
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> <repository name='repoB'> <path project='home:tom:projectA' repository='repoA' /> <arch>i586</arch> </repository> </project>"
assert_response :success
# delete the project including the repository
delete "/source/home:tom:projectA"
assert_response 403
assert_xml_tag( :tag => "status", :attributes => { :code => "repo_dependency"} )
delete "/source/home:tom:projectA?force=1"
assert_response :success
get "/source/home:tom:projectB/_meta"
assert_response :success
assert_xml_tag :tag => 'path', :attributes => { :project => "deleted", :repository => "deleted" }
put "/source/home:tom:projectB/_meta", "<project name='home:tom:projectB'> <title/> <description/> </project>"
assert_response :success
# cleanup
delete "/source/home:tom:projectB"
assert_response :success
end
def test_delete_project_with_local_devel_packages
prepare_request_with_user "tom", "thunder"
put "/source/home:tom:project/_meta", "<project name='home:tom:project'> <title/> <description/> <repository name='repoA'> <arch>i586</arch> </repository> </project>"
assert_response :success
put "/source/home:tom:project/A/_meta", "<package name='A' project='home:tom:project'> <title/> <description/></package>"
assert_response :success
put "/source/home:tom:project/B/_meta", "<package name='B' project='home:tom:project'> <title/> <description/> <devel package='A'/> </package>"
assert_response :success
put "/source/home:tom:project/C/_meta", "<package name='C' project='home:tom:project'> <title/> <description/> <devel package='B'/> </package>"
assert_response :success
# delete the project including the packages
delete "/source/home:tom:project"
assert_response :success
end
def test_devel_project_cycle
prepare_request_with_user "tom", "thunder"
put "/source/home:tom:A/_meta", "<project name='home:tom:A'> <title/> <description/> </project>"
assert_response :success
put "/source/home:tom:B/_meta", "<project name='home:tom:B'> <title/> <description/> <devel project='home:tom:A'/> </project>"
assert_response :success
get "/source/home:tom:B/_meta"
assert_response :success