/
request_controller.rb
428 lines (370 loc) · 14.7 KB
/
request_controller.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
require 'base64'
class Webui::RequestController < Webui::WebuiController
include Webui::WebuiHelper
include Webui::HasComments
helper 'webui/comment'
helper 'webui/package'
before_filter :require_login, :only => [:save_comment]
# requests do not really add much value for our page rank :)
before_filter :lockout_spiders
before_filter :require_request, only: [:changerequest]
def add_reviewer_dialog
@request_id = params[:id]
render_dialog 'requestAddReviewAutocomplete'
end
def add_reviewer
required_parameters :review_type
begin
opts = {}
case params[:review_type]
when 'user' then
opts[:by_user] = params[:review_user]
when 'group' then
opts[:by_group] = params[:review_group]
when 'project' then
opts[:by_project] = params[:review_project]
when 'package' then
opts[:by_project] = params[:review_project]
opts[:by_package] = params[:review_package]
end
opts[:comment] = params[:review_comment] if params[:review_comment]
req = BsRequest.find_by_id(params[:id])
req.addreview(opts)
rescue BsRequestPermissionCheck::AddReviewNotPermitted
flash[:error] = "Unable add review to '#{params[:id]}'"
end
redirect_to :controller => :request, :action => 'show', :id => params[:id]
end
def modify_review
opts = {}
state = nil
req = nil
params.each do |key, value|
state = key if %w(accepted declined new).include? key
req = BsRequest.find_by_id(value) if key.starts_with?('review_request_id_')
# Our views are valid XHTML. So, several forms 'POST'-ing to the same action have different
# HTML ids. Thus we have to parse 'params' a bit:
opts[:comment] = value if key.starts_with?('review_comment_')
opts[:by_user] = value if key.starts_with?('review_by_user_')
opts[:by_group] = value if key.starts_with?('review_by_group_')
opts[:by_project] = value if key.starts_with?('review_by_project_')
opts[:by_package] = value if key.starts_with?('review_by_package_')
end
if req.nil?
flash[:error] = "Unable to load request"
redirect_back_or_to user_requests_path(User.current)
return
elsif state.nil?
flash[:error] = "Unknown state to set"
else
req.permission_check_change_review!(opts)
req.change_review_state(state, opts)
end
redirect_to :action => 'show', :id => req.id
end
def show
redirect_back_or_to user_requests_path(User.current) and return if !params[:id]
begin
@req = BsRequest.find(params[:id])
rescue ActiveRecord::RecordNotFound
flash[:error] = "Can't find request #{params[:id]}"
redirect_back_or_to user_requests_path(User.current) and return
end
@req = @req.webui_infos
@id = @req['id']
@state = @req['state'].to_s
@accept_at = @req['accept_at']
@req['creator'] = User.find_by_login! @req['creator']
@is_author = @req['creator'] == User.current
@superseded_by = @req['superseded_by']
@superseding = @req['superseding']
@is_target_maintainer = @req['is_target_maintainer']
@my_open_reviews = @req['my_open_reviews']
@other_open_reviews = @req['other_open_reviews']
@can_add_reviews = %w(new review).include?(@state) && (@is_author || @is_target_maintainer || @my_open_reviews.length > 0) && !User.current.is_nobody?
@can_handle_request = %w(new review declined).include?(@state) && (@is_target_maintainer || @is_author) && !User.current.is_nobody?
@events = @req['events']
@actions = @req['actions']
request_list = session[:requests]
@request_before = nil
@request_after = nil
index = request_list.index(@id) if request_list
if index and index > 0
@request_before = request_list[index-1]
end
if index
# will be nul for after end
@request_after = request_list[index+1]
end
sort_comments(BsRequest.find(params[:id]).comments)
end
def sourcediff
check_ajax
render :partial => 'shared/editor', :locals => {:text => params[:text], :mode => 'diff', :read_only => true, :height => 'auto', :width => '750px', :no_border => true, uid: params[:uid]}
end
def require_request
required_parameters :id
@req = BsRequest.find params[:id]
unless @req
flash[:error] = "Can't find request #{params[:id]}"
redirect_back_or_to user_requests_path(User.current) and return
end
end
def changerequest
changestate = nil
%w(accepted declined revoked new).each do |s|
if params.has_key? s
changestate = s
break
end
end
if change_state(changestate, params)
# TODO: Make this work for each submit action individually
if params[:add_submitter_as_maintainer_0]
if changestate != 'accepted'
flash[:error] = 'Will not add maintainer for not accepted requests'
else
tprj, tpkg = params[:add_submitter_as_maintainer_0].split('_#_') # split into project and package
if tpkg
target = Package.find_by_project_and_name(tprj, tpkg)
else
target = Project.Project.find_by_name tprj
end
target.add_user(@req.creator, 'maintainer')
target.save
end
end
end
accept_request if changestate == 'accepted'
redirect_to :action => 'show', :id => params[:id]
end
def accept_request
flash[:notice] = "Request #{params[:id]} accepted"
# Check if we have to forward this request to other projects / packages
params.keys.grep(/^forward_.*/).each do |fwd|
forward_request_to(fwd)
end
end
def forward_request_to(fwd)
tgt_prj, tgt_pkg = params[fwd].split('_#_') # split off 'forward_' and split into project and package
description = @req.description
who = @req.creator.login
description += ' (forwarded request %d from %s)' % [params[:id], who]
target = @req.find_first(:action).find_first(:target)
rev = Package.dir_hash(target.value(:project), target.value(:package))['rev']
req = nil
begin
BsRequest.transaction do
req = BsRequest.new
req.state = "new"
req.description = params[:description]
opts = { source_project: target.value(:project),
source_package: target.value(:package),
source_rev: rev,
target_project: tgt_prj,
target_package: tgt_pkg }
if params[:sourceupdate]
opts[:sourceupdate] = params[:sourceupdate]
elsif params[:project].include?(':branches:')
opts[:sourceupdate] = 'update' # Avoid auto-removal of branch
end
action = BsRequestActionSubmit.new(opts)
req.bs_request_actions << action
action.bs_request = req
req.save!
end
rescue BsRequestAction::UnknownProject,
BsRequestAction::UnknownTargetPackage => e
flash[:error] = "Unable to forward submit: #{e.message}"
redirect_to(:action => 'show', :project => params[:project], :package => params[:package]) and return
end
# link_to isn't available here, so we have to write some HTML. Uses url_for to not hardcode URLs.
flash[:notice] += " and forwarded to <a href='#{url_for(:controller => 'package', :action => 'show', :project => tgt_prj, :package => tgt_pkg)}'>#{tgt_prj} / #{tgt_pkg}</a> (request <a href='#{url_for(:action => 'show', :id => req.id)}'>#{req.id}</a>)"
end
def diff
# just for compatibility. OBS 1.X used this route for show
redirect_to :action => :show, :id => params[:id]
end
def list
redirect_to user_requests_path(User.current) and return unless request.xhr? # non ajax request
requests = BsRequestCollection.list_ids(params)
elide_len = 44
elide_len = params[:elide_len].to_i if params[:elide_len]
session[:requests] = requests
requests = BsRequestCollection.new(ids: session[:requests]).relation
render :partial => 'shared/requests', :locals => {:requests => requests, :elide_len => elide_len, :no_target => params[:no_target]}
end
def list_small
required_parameters :project # the minimum
redirect_to user_requests_path(User.current) and return unless request.xhr? # non ajax request
requests = BsRequestCollection.list_ids(params)
requests = BsRequestCollection.new(ids: requests).relation
render partial: 'requests_small', locals: {requests: requests}
end
def delete_request_dialog
@project = params[:project]
@package = params[:package] if params[:package]
render_dialog
end
def delete_request
required_parameters :project
req=nil
begin
BsRequest.transaction do
req = BsRequest.new
req.state = "new"
req.description = params[:description]
opts = {target_project: params[:project]}
opts[:target_package] = params[:package] if params[:package]
opts[:target_repository] = params[:repository] if params[:repository]
action = BsRequestActionDelete.new(opts)
req.bs_request_actions << action
action.bs_request = req
req.save!
end
flash[:success] = "Created <a href='#{url_for(:controller => 'request', :action => 'show', :id => req.id)}'>repository delete request #{req.id}</a>"
rescue BsRequestAction::UnknownTargetProject,
BsRequestAction::UnknownTargetPackage => e
flash[:error] = e.message
redirect_to :controller => :package, :action => :show, :package => params[:package], :project => params[:project] and return if params[:package]
redirect_to :controller => :project, :action => :show, :project => params[:project] and return
end
redirect_to :controller => :request, :action => :show, :id => req.id
end
def add_role_request_dialog
@project = params[:project]
@package = params[:package] if params[:package]
render_dialog
end
def add_role_request
required_parameters :project, :role
req=nil
begin
BsRequest.transaction do
req = BsRequest.new
req.state = "new"
req.description = params[:description]
opts = {target_project: params[:project],
role: params[:role]}
opts[:target_package] = params[:package] if params[:package]
opts[:person_name] = params[:user] if params[:user]
opts[:group_name] = params[:group] if params[:group]
action = BsRequestActionAddRole.new(opts)
req.bs_request_actions << action
action.bs_request = req
req.save!
end
rescue BsRequestAction::UnknownTargetProject,
BsRequestAction::UnknownTargetPackage => e
flash[:error] = e.message
redirect_to :controller => :package, :action => :show, :package => params[:package], :project => params[:project] and return if params[:package]
redirect_to :controller => :project, :action => :show, :project => params[:project] and return
end
redirect_to :controller => :request, :action => :show, :id => req.id
end
def set_bugowner_request_dialog
render_dialog
end
def set_bugowner_request
required_parameters :project, :user, :group
req=nil
begin
BsRequest.transaction do
req = BsRequest.new
req.state = "new"
req.description = params[:description]
opts = {target_project: params[:project]}
opts[:target_package] = params[:package] if params[:package]
opts[:person_name] = params[:user] if params[:user]
opts[:group_name] = params[:group] if params[:group]
action = BsRequestActionSetBugowner.new(opts)
req.bs_request_actions << action
action.bs_request = req
req.save!
end
rescue BsRequestAction::UnknownTargetProject,
BsRequestAction::UnknownTargetPackage => e
flash[:error] = e.message
redirect_to :controller => :package, :action => :show, :package => params[:package], :project => params[:project] and return if params[:package]
redirect_to :controller => :project, :action => :show, :project => params[:project] and return
end
redirect_to :controller => :request, :action => :show, :id => req.id
end
def change_devel_request_dialog
required_parameters :package, :project
@project = WebuiProject.find params[:project]
@package = Package.find_by_project_and_name(params[:project], params[:package])
if @package.develpackage
@current_devel_package = @package.develpackage.name
@current_devel_project = @package.develpackage.project.name
end
render_dialog
end
def change_devel_request
required_parameters :devel_project, :package, :project
req=nil
begin
BsRequest.transaction do
req = BsRequest.new
req.state = "new"
req.description = params[:description]
opts = {target_project: params[:project],
target_package: params[:package],
source_project: params[:devel_project],
source_package: params[:devel_package] || params[:package]}
action = BsRequestActionChangeDevel.new(opts)
req.bs_request_actions << action
action.bs_request = req
req.save!
end
rescue BsRequestAction::UnknownProject,
Package::UnknownObjectError,
Package::ReadAccessError,
BsRequestAction::UnknownTargetPackage => e
flash[:error] = "No such package: #{e.message}"
redirect_to :controller => 'package', :action => 'show', :project => params[:project], :package => params[:package] and return
end
redirect_to :controller => 'request', :action => 'show', id: req.id
end
def set_incident_dialog
render_dialog
end
def set_incident
req = BsRequest.find_by_id(params[:id])
if req.nil?
flash[:error] = "Unable to load request"
elsif params[:incident_project].blank?
flash[:error] = "Unknown incident project to set"
else
begin
req.permission_check_setincident!(params[:incident_project])
req.setincident(params[:incident_project])
flash[:notice] = "Set target of request #{req.id} to incident #{params[:incident_project]}"
rescue Project::UnknownObjectError => e
flash[:error] = "Incident #{e.message} does not exist"
end
end
redirect_to :action => 'show', :id => params[:id]
end
# used by mixins
def main_object
BsRequest.find params[:id]
end
private
def change_state(newstate, params)
req = BsRequest.find_by_id(params[:id])
if req.nil?
flash[:error] = "Unable to load request"
else
# FIXME: make force optional, it hides warnings!
opts = { :newstate=>newstate,
:force => true,
:user => User.current.login,
:comment => params[:reason] }
req.change_state(opts)
flash[:notice] = "Request #{newstate}!"
return true
end
return false
end
end