Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM/CI: Report pending status for multibuilds #12121

Closed
perlpunk opened this issue Jan 24, 2022 · 15 comments · Fixed by #12138
Closed

SCM/CI: Report pending status for multibuilds #12121

perlpunk opened this issue Jan 24, 2022 · 15 comments · Fixed by #12138
Labels
Documentation 📖 Things regarding our documentation Frontend Things related to the OBS RoR app scm-ci Things related to the scm-ci feature

Comments

@perlpunk
Copy link
Contributor

We are about to use the SCM/CI for openQA projects.
We are using multibuilds, and it is a documented limitation, that multibuilds don't report a pending status, but only report the final fail or success.
https://openbuildservice.org/help/manuals/obs-user-guide/cha.obs.scm_ci_workflow_integration.html#sec.obs.obs_scm_ci_workflow_integration.setup.status_reporting

This can be problematic because when looking at a PR, one doesn't even know if there are still running checks, and we have a lot of checks.
A PR might get merged because every check passes.
We also use mergify to automatically merge in certain conditions, and we have to manually add every OBS build/platform to the configuration to be sure that it doesn't merge before those checks are reported.

So it would be nice if the pending status could also be reported.

@dmarcoux dmarcoux added the Documentation 📖 Things regarding our documentation label Jan 24, 2022
@dmarcoux
Copy link
Contributor

This isn't true anymore and the documentation needs to be updated. The build status of multibuild flavors is reported. Thank you for reporting this @perlpunk.

@dmarcoux dmarcoux self-assigned this Jan 24, 2022
@perlpunk
Copy link
Contributor Author

@dmarcoux oh, since when does that work?
It wasn't working yet last friday:
perlpunk/os-autoinst#12
You can see the checks are all reported, but they only appeared when they were finished, not during the running check.

@dmarcoux
Copy link
Contributor

Hum... I'll need to double-check, but I'm pretty sure the initial report is working.

@dmarcoux dmarcoux added the Bug label Jan 24, 2022
@dmarcoux
Copy link
Contributor

It's not working somehow, we need to investigate. Thank you again for reporting this.

@dmarcoux dmarcoux removed their assignment Jan 26, 2022
@vpereira
Copy link
Contributor

Tested locally on master and I couldn't reproduce it.

Screenshot_2022-01-26_13-05-08

@perlpunk
Copy link
Contributor Author

@vpereira I will try again right now and create a PR in https://github.com/os-autoinst/os-autoinst/pulls and ping you directly after it. maybe you can see it

@dmarcoux
Copy link
Contributor

@perlpunk I had a look at the PR and the initial report with the "pending" status weren't reported. It is the same that I experienced in a test I did.

@okurz
Copy link
Member

okurz commented Jan 26, 2022

So seems like there seems to a little difference in what you guys, @dmarcoux and @vpereira did? I read that at least there is the difference between "what is deployed+configured to build.opensuse.org" and "locally on master", right?

@vpereira
Copy link
Contributor

@vpereira I will try again right now and create a PR in https://github.com/os-autoinst/os-autoinst/pulls and ping you directly after it. maybe you can see it

As we talked privately, our issue is that we cannot reproduce it in development, but as @dmarcoux said he is able to reproduce in production. We are still investigating the issue.

@dmarcoux
Copy link
Contributor

This was closed by mistake, there's still more to do for this. Reopening.

@dmarcoux dmarcoux reopened this Jan 31, 2022
@perlpunk
Copy link
Contributor Author

perlpunk commented Feb 2, 2022

One more thing, I don't know if it's related: builds that are unresolvable are also not reported.
Example: os-autoinst/openQA#4494
I would expect them to be reported as failures.

@dmarcoux
Copy link
Contributor

dmarcoux commented Feb 2, 2022

Yes, this is sadly not implemented. We're tracking this in https://trello.com/c/0N3jHq5M/2257-report-back-to-scm-when-build-results-arent-failed-and-succeeded

@perlpunk
Copy link
Contributor Author

perlpunk commented Feb 2, 2022

ok thanks

@JanZerebecki
Copy link
Member

This will be important for ALP/Git.

@hennevogel hennevogel added scm-ci Things related to the scm-ci feature Frontend Things related to the OBS RoR app and removed Bug labels May 5, 2023
@hennevogel
Copy link
Member

As we are tracking this in our backlog, let's close this issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📖 Things regarding our documentation Frontend Things related to the OBS RoR app scm-ci Things related to the scm-ci feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants