Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only report initial status for events that will report status to SCM #12665

Open
hennevogel opened this issue Jun 2, 2022 · 1 comment
Open
Labels
Bug Frontend Things related to the OBS RoR app scm-ci Things related to the scm-ci feature

Comments

@hennevogel
Copy link
Member

hennevogel commented Jun 2, 2022

Token::Workflow runs ScmInitialStatusReporter for all events. No matter if they will produce status or not. For instance for a pull_request/close hook. This will delete the project of the test build and never report anything again. No need for some initial status report...

@ailin-nemui reported that on IRC

This happens here:

SCMStatusReporter.new(@scm_webhook.payload, @scm_webhook.payload, scm_token, workflow_run, initial_report: true).call
@workflows.each do |workflow|
return workflow.errors.full_messages if workflow.invalid?(:call)
workflow.call
end
SCMStatusReporter.new(@scm_webhook.payload, @scm_webhook.payload, scm_token, workflow_run, 'success', initial_report: true).call

@hennevogel hennevogel added Bug Frontend Things related to the OBS RoR app Beta Feedback about things currently in our beta program labels Jun 2, 2022
@dmarcoux
Copy link
Contributor

@hennevogel hennevogel removed the Beta Feedback about things currently in our beta program label May 5, 2023
@hennevogel hennevogel added the scm-ci Things related to the scm-ci feature label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Frontend Things related to the OBS RoR app scm-ci Things related to the scm-ci feature
Projects
None yet
Development

No branches or pull requests

2 participants