Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error validation display in the modals #7011

Open
hennevogel opened this issue Feb 20, 2019 · 10 comments
Open

Error validation display in the modals #7011

hennevogel opened this issue Feb 20, 2019 · 10 comments
Labels
Bootstrap 🚀 Bootstrap migration Frontend Things related to the OBS RoR app Refactoring 🏭

Comments

@hennevogel
Copy link
Member

Today if you are working with a modal, there is a error after the submission, the modal is closed and the error is displayed in the main page, making you loose what you typed in the modal.. maybe would be better to have a feedback inline inside the modal?

@Ana06
Copy link
Member

Ana06 commented Apr 16, 2019

many modals have the feedback. What modal do you specifically speak about?

@hennevogel
Copy link
Member Author

peekM32N0Z

@hennevogel
Copy link
Member Author

There are many of those.

@Ana06 Ana06 self-assigned this Apr 23, 2019
@Ana06
Copy link
Member

Ana06 commented Apr 24, 2019

@hennevogel the case you mention, it is not really a validation. I mean, we would have to look for the package with ajax to know if it exists.... I personally think that this case is fine.

@hennevogel
Copy link
Member Author

If it's a validation or not doesn't really matter right?

@Ana06
Copy link
Member

Ana06 commented Apr 24, 2019

@hennevogel

If it's a validation or not doesn't really matter right?

it does. There are things that you don't know if fail until you actually try them, like the case you selected.

@hennevogel
Copy link
Member Author

Sure, but what has that to do with the modal/UI?

@Ana06
Copy link
Member

Ana06 commented Apr 24, 2019

We would have to make slower the workflow (the user can not press send until we check the package exits) to be able to validate it. You also have to face the problem that the package was created/deleted during the modal interaction and render this properly to the user.

@hennevogel
Copy link
Member Author

You would have to help the user to input the correct things, yes.

@hennevogel
Copy link
Member Author

@hennevogel hennevogel added the Frontend Things related to the OBS RoR app label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap 🚀 Bootstrap migration Frontend Things related to the OBS RoR app Refactoring 🏭
Projects
None yet
Development

No branches or pull requests

2 participants