Collapsible Comments

[dmarcoux]

Is your feature request related to a problem? Please describe.
On a page with lots of comments, especially on the request overview, it can be annoying to scroll for a while to get to the decision box (especially on mobile)

Describe the solution you'd like
I would like to collapse comments one by one and also have the possibility to collapse the comments box.

Describe alternatives you've considered
Links to jump to a section of a page would be nice too, but it would change depending on the pages where comments are displayed. The collapsible comments is more generic.

Additional context
We should also have this on other pages where comments are displayed.

[Ana06]

what about moving the box up? If I have understood your proposal right, if I would like to read the whole conversation I would have to uncollapse all the comments.

[dmarcoux]

It could be a solution since I believe the decision box is more important than comments (or at least, this is what I think). However, we should check with users which are using the request workflow everyday/often to know what they think.

[coolo]

comments are the reason why it's not yet accepted - so ignoring them can be very counterproductive. I wonder what your user story is that you want to ignore comments.

[coolo]

I mean would you ignore comments in a github PR and scroll down right to the merge button?

[dmarcoux]

I like your analogy with GitHub. It's true that I wouldn't skip comments on a GitHub PR/issue. It's more their number which is making them annoying, because of how we present them. Perhaps we need to display them more efficiently/concisely. I believe it's another example of the issue #6587.

[coolo]

but what request did you look at with a lot of comments? I'm more annoyed by the long diffs sometimes

[dmarcoux]

Sorry, but I don't have an example right now, but I've seen some requests with a lot of comments before.

[coolo]

Well, OBS database to the rescue.

We have https://build.opensuse.org/request/show/477768 with 42 comments and https://build.opensuse.org/request/show/650561 with 41 comments as absolute record holders.

And both examples IMO prove my point, neither I would blindly accept without going through (or being familiar with) that discussion.

comment count on obs:

0+: 675561
1+: 64187
2+: 11639
3+: 4247
4+: 2341

... it's going downhill fast. But a more realistic noisy request could be https://build.opensuse.org/request/show/687544

And what I think indeed sounds useful is to have an option to collapse a thread. Not a single comment, not all comments, but a thread. Collapsing the full comments box collides with my goal of intersecting comments and review, which IMO belong together.

[coolo]

And compared to https://build.opensuse.org/request/show/691285 I wouldn't worry about the comments too much.