Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments of superseeded requests disappeared #7456

Open
AdamMajer opened this issue Apr 24, 2019 · 3 comments
Open

Comments of superseeded requests disappeared #7456

AdamMajer opened this issue Apr 24, 2019 · 3 comments
Labels
Feature Frontend Things related to the OBS RoR app

Comments

@AdamMajer
Copy link
Member

Issue Description

Comments of superseded requests are disappearing, after 2nd supersede.

Using Beta UI.

Expected Result

See comments.

How to Reproduce

  1. Go to https://build.opensuse.org/request/show/697564
  2. See only comments of superseded request.
  3. Click on 697562 (superseded request)
  4. Scroll down to Comments
  5. See Comments of current and previous request which was missing from 1 above.

Maybe this should be reworked to two panes - current comments, superseded requests comments, which would include the entire superseded tree.

@hennevogel hennevogel added Bootstrap 🚀 Bootstrap migration Bug Frontend Things related to the OBS RoR app labels Apr 24, 2019
@DavidKang DavidKang self-assigned this May 16, 2019
@hennevogel
Copy link
Member

@saraycp
Copy link
Contributor

saraycp commented Jun 10, 2019

Trying the same workflow in the old UI, it seems the behavior is the same as before. I don't think this is a bug/regression and I'm not sure if we want to change it. 🤔

Adding all the superseded comments in the last request page, could imply having too many comment's tabs or even a huge tree of comments if all of them were in the same tab. Nowadays, we can read the comments anyway, by clicking on the previous requests, what I think is not a big deal.

@saraycp saraycp self-assigned this Jun 10, 2019
@hennevogel hennevogel added Feature and removed Bootstrap 🚀 Bootstrap migration Bug labels Jun 13, 2019
@coolo
Copy link
Member

coolo commented Oct 10, 2019

Unassign then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

5 participants