Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ordering in data tables with new Ajax requests #7508

Open
mschnitzer opened this issue Apr 29, 2019 · 3 comments
Open

Avoid ordering in data tables with new Ajax requests #7508

mschnitzer opened this issue Apr 29, 2019 · 3 comments
Labels
Bootstrap 🚀 Bootstrap migration Feature Frontend Things related to the OBS RoR app

Comments

@mschnitzer
Copy link
Member

Is your feature request related to a problem? Please describe.
The maintenance overview page has now been refactored and I just tested the new ordering feature for the datatables. However, when I clicked the arrow down/arrow up to order by the summary, nothing happened. After a while I was just scrolling around on that page to see what else has been changed and then the whole data table was refreshed. I was a bit confused and then I realized that the ordering (which seemed to not work before) just fetched the whole data records via Ajax again and after its completion (which took 18,2 seconds) it was replaced with the old table.

This is really confusing because you expect the ordering to happen within milliseconds and being done by your browser instead of querying information from the database again.

Describe the solution you'd like
Order in the browser, not via an Ajax call.

Describe alternatives you've considered
n/a

Additional context
n/a

@saraycp saraycp added Bootstrap 🚀 Bootstrap migration Bug Frontend Things related to the OBS RoR app labels Apr 29, 2019
@bgeuken
Copy link
Member

bgeuken commented Apr 29, 2019

Order in the browser, not via an Ajax call.

This would only be possible without using server side pagination.

Seems we would have to make this page / querying incidents much faster before the ordering option is of any user. Until then we should disable it.

@vpereira
Copy link
Contributor

Either you load everything and then allow the user to paginate it locally in the browser or you use pagination, getting the initial results fast but then hitting the server again if you need to resort it.. I think that's an expected dichotomy

@mschnitzer
Copy link
Member Author

Maybe this one is not needed when #7507 is implemented. This would at least solve the issue on the maintenance page. Not sure if it's a problem for other pages as well.

@hennevogel hennevogel added Feature and removed Bug labels Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bootstrap 🚀 Bootstrap migration Feature Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

5 participants