Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate reviews for a request #7568

Open
dmarcoux opened this issue May 15, 2019 · 2 comments
Open

Duplicate reviews for a request #7568

dmarcoux opened this issue May 15, 2019 · 2 comments
Labels
Bug Frontend Things related to the OBS RoR app

Comments

@dmarcoux
Copy link
Contributor

dmarcoux commented May 15, 2019

Issue Description

It's possible to add a duplicate review for a request. For example, if I added a review for the user Iggy, I can add another review for him again.

Expected Result

I expect this to not be possible, unless the previous review isn't open anymore (it was approved/rejected).

How to Reproduce

  1. Go to a request overview page for which you can add reviews.
  2. Click on Add a review
  3. Add a review for a user
  4. Add it again
  5. See the duplicate reviews

Further Information

duplicate-review

@dmarcoux dmarcoux added Bug Frontend Things related to the OBS RoR app labels May 15, 2019
@coolo
Copy link
Member

coolo commented May 15, 2019

unfortunately there is a requirement from (previous) customers to have that. And we even have a test case to avoid regressing this: test_create_request_and_multiple_reviews

@coolo
Copy link
Member

coolo commented May 15, 2019

I don't think the webui needs to support this - but abstain from thinking in terms of model validations :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

2 participants