Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new UI request accept has no "Accept/Decline" buttons in some forms #7978

Open
msmeissn opened this issue Jul 26, 2019 · 7 comments
Open

new UI request accept has no "Accept/Decline" buttons in some forms #7978

msmeissn opened this issue Jul 26, 2019 · 7 comments
Labels
Bug Frontend Things related to the OBS RoR app

Comments

@msmeissn
Copy link
Member

Issue Description

The new UI is not showing the Accept or Decline button for a Submitrequest

https://build.opensuse.org/request/show/714571

The reason seems it shows the superseded request too, and this seems to confuse the logic perhaqps?

Expected Result

The page should have Accept or Decline button.

How to Reproduce

  1. Go to https://build.opensuse.org/request/show/714571
  2. Scroll down to the bottom, look for the buttons to accept/decline
  3. Fail to find the buttons.

Further Information

@coolo
Copy link
Member

coolo commented Jul 26, 2019

A little hard to reproduce - as that request is accepted now

@hennevogel hennevogel self-assigned this Jul 26, 2019
@msmeissn
Copy link
Member Author

it ,might have been accepted already, but it was still showing "new" on the top as I looked at it

@hennevogel
Copy link
Member

it ,might have been accepted already, but it was still showing "new" on the top as I looked at it

the decision to show the buttons is made during rendering the page and is not updated afterward...

@hennevogel
Copy link
Member

@msmeissn this was the only example you had or did you see this in any other request as well?

@hennevogel hennevogel removed their assignment Jul 26, 2019
@hennevogel hennevogel added Bug Frontend Things related to the OBS RoR app P1 EVERYONE drop everything and fix this NOW and removed P1 EVERYONE drop everything and fix this NOW labels Jul 26, 2019
@hennevogel
Copy link
Member

hennevogel commented Jul 26, 2019

We tried to reproduce this (718820) but couldn't in any way.

Are you sure you weren't looking at the superseded request?

@msmeissn
Copy link
Member Author

i opened it from my request list.. hmm.
i would monitor but this might just be a fluke right now

@hennevogel
Copy link
Member

I opened it from my request list.. hmm.

That one also renders, then never updates again. If, in the meantime, a request is superseded...

i would monitor but this might just be a fluke right now

Please do so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

3 participants