Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing details from error for commit of invalid .product #8338

Open
JanZerebecki opened this issue Sep 13, 2019 · 1 comment
Open

missing details from error for commit of invalid .product #8338

JanZerebecki opened this issue Sep 13, 2019 · 1 comment
Labels
Backend Things regarding the OBS backend Feature

Comments

@JanZerebecki
Copy link
Member

Issue Description

When committing a change to a .product file with invald xml the error message is missing the details.

Expected Result

_product $ osc commit
Sending some.product
Server returned an error: HTTP Error 400: Bad Request
FAILED: Unable to parse /bs/sources/:upload/expandproduct_20294/some.product: 
-:114: parser error : Opening and ending tag mismatch: include line 110 and packagelist
       </packagelist>
                     ^
-:115: parser error : Opening and ending tag mismatch: packagelist line 109 and group
    </group>
            ^
-:130: parser error : Opening and ending tag mismatch: group line 108 and productdefinition
</productdefinition>
                    ^
-:131: parser error : Premature end of data in tag productdefinition line 2

^

The file in question was https://gist.github.com/brett060102/d2df730b8b992f2b5053e7b60adbdb45 and I copied in the error message from running xmllint on that file.

How to Reproduce

$ osc bco some:procject/_product

# remove a / from a self closing element in some.product

_product $ osc commit
Sending some.product
Server returned an error: HTTP Error 400: Bad Request
FAILED: Unable to parse /bs/sources/:upload/expandproduct_20294/some.product: 

The error message is cut short.

Further Information

  • A link to an OBS instance showing the issue: build.suse.de
@JanZerebecki
Copy link
Member Author

The message originates here:

die("FAILED: Unable to parse $filename: $@");

Maybe the error details are passed somewhere else or the error reporting of the xml parser needs to be enabled.

@hennevogel hennevogel added Backend Things regarding the OBS backend Feature labels Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Things regarding the OBS backend Feature
Projects
None yet
Development

No branches or pull requests

2 participants