Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a mean to overwrite group icon for staging dashboard #8740

Open
coolo opened this issue Nov 18, 2019 · 6 comments
Open

Provide a mean to overwrite group icon for staging dashboard #8740

coolo opened this issue Nov 18, 2019 · 6 comments
Labels
Feature staging-workflow Things related to the staging workflow feature

Comments

@coolo
Copy link
Member

coolo commented Nov 18, 2019

In the light of #8735, I set gravatar icons for the review groups involved in leap reviews and I can't say it improves the page.

While gravatar icons (while too large) make it nicely obvious that we're looking for a review from @mschnitzer in one case:
screencapture-1

16x16 pixels make it really hard to find an avatar that renders okayish (especially on that orange background :)
screencapture-2

Having a fontawesome pick to be scaled to the exact size needed would improve overview by a lot. Forcing users to pick a gravatar that looks like a logo on the dashboard does not work :(

@coolo coolo added Feature staging-workflow Things related to the staging workflow feature Design Issues about the design of a page labels Nov 18, 2019
@lnussel
Copy link
Member

lnussel commented Nov 19, 2019

👍

@coolo
Copy link
Member Author

coolo commented Nov 21, 2019

This just became a blocker as I noticed that adding dummy email addresses to groups disables email notificatons to group members. As such I will remove the dummy email addresses again - and then we're back to all review groups looking like me.

@coolo coolo added the P3 label Nov 21, 2019
@coolo coolo added this to the Staging Switch milestone Nov 21, 2019
@coolo coolo removed the P3 label Nov 21, 2019
@mschnitzer
Copy link
Member

reviewed btw ;-)

@coolo
Copy link
Member Author

coolo commented Nov 22, 2019

you broke my test case? :)

@mschnitzer
Copy link
Member

@coolo I'll work on it next week ;-)

@coolo
Copy link
Member Author

coolo commented Nov 26, 2019

So many coolos!

screencapture-build-suse-de-staging-workflows-9-2019-11-26-17_28_27

@hennevogel hennevogel removed the Design Issues about the design of a page label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature staging-workflow Things related to the staging workflow feature
Projects
None yet
Development

No branches or pull requests

4 participants