Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting a submit request deletes the source package even if there are changes #9241

Open
Vogtinator opened this issue Mar 17, 2020 · 2 comments
Labels
Frontend Things related to the OBS RoR app

Comments

@Vogtinator
Copy link
Member

  1. Branch a package, make some changes
  2. Make a submit request with those changes
  3. Make further changes to the branched package
  4. Accept the request from 2

Expected result: The package is not deleted

What happens: The package is deleted

If it weren't for osc undelete, this causes work to be lost.

@adrianschroeter
Copy link
Member

adrianschroeter commented Mar 17, 2020 via email

@Vogtinator
Copy link
Member Author

I don't want just to skip a former wanted action at least (the removal).

It's not really "actively" wanted as it's just the default for submit requests from ~:branch projects.

The principle of least surprise would say that deleting the newest state because an older state was enabled for cleanup doesn't really make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

No branches or pull requests

3 participants