Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISO changelog extracter creates empty files #2128

Closed
DimStar77 opened this issue Jul 16, 2019 · 7 comments
Closed

ISO changelog extracter creates empty files #2128

DimStar77 opened this issue Jul 16, 2019 · 7 comments
Labels

Comments

@DimStar77
Copy link
Contributor

The changelog extractor, which is used to produce the announcement mails to openSUSE-Factory,produces empty files, i.e.

-rw-r--r-- 1 geekotest    nogroup 5332445 Jul  9 02:30 20190708
-rw-r--r-- 1 geekotest    nogroup      26 Jul 10 23:07 20190709
-rw-r--r-- 1 geekotest    nogroup      26 Jul 11 20:13 20190711
-rw-r--r-- 1 geekotest    nogroup      26 Jul 15 15:11 20190713
@DimStar77 DimStar77 added the P1 label Jul 16, 2019
@DimStar77
Copy link
Contributor Author

This is potentially a fallout from the upgrade of ariel to Leap 15.1:

2019-07-09 19:31:10|command|root@ariel|'zypper' '-n' '--releasever=15.1' 'dup' '--auto-agree-with-licenses' '--replacefiles' '--download-in-advance'|
2019-07-09 19:31:11|remove |ruby2.1-rubygem-json_pure|1.8.2-6.3|x86_64||

CC @okurz

@DimStar77
Copy link
Contributor Author

e.g.

/opt/openqa-scripts/factory-package-news.py save --dir /var/lib/snapshot-changes/microos/Tumbleweed/ --snapshot 20190613 /var/lib/openqa/factory/iso/openSUSE-MicroOS-DVD-x86_64-Snapshot20190713-Media.iso 
++ WARN: from_733: broken byte order
++ WARN: Bad directory information for suse
++ WARN: from_733: broken byte order
++ WARN: Bad directory information for suse
++ WARN: from_733: broken byte order
++ WARN: Bad directory information for x86_64
++ WARN: from_733: broken byte order
++ WARN: Bad directory information for noarch

@DimStar77
Copy link
Contributor Author

from_733: broken byte order is a message from libcdio

@DimStar77
Copy link
Contributor Author

@coolo
Copy link
Member

coolo commented Jul 16, 2019

the warning have been there since about forever. I don't think they are your problem.

@DimStar77
Copy link
Contributor Author

http://git.savannah.gnu.org/cgit/libcdio.git/commit/?id=8be41a36b8792b7d99fc8383a6c426d8b63ec6a8 - new in libcdio 0.94 - which came with Leap 15.0 - 42.3 was at libcdio 0.93

@DimStar77
Copy link
Contributor Author

I backported two patches from libcdio 2.1 to the Leap 15.1 provided libcdio 0.94.
The patched version of libcdio is currently installed on ariel - and the changelog extractor is functional again (diff of 0713->0716 https://openqa.opensuse.org/factory-package-news/diff/20190716)

In parallel, I submitted my fixed version of libcdio into the SLE15 maintenance process

As such, I think we can safely close this issue: nothing needed be done in the releng tooling, the bug was introduced by upgrading to Leap 15.1 (well, not really - the bug is ultimately in the product builder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants