Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include pamixer in the pattern #32

Closed
dive-deeper opened this issue Jan 17, 2021 · 9 comments
Closed

Include pamixer in the pattern #32

dive-deeper opened this issue Jan 17, 2021 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@dive-deeper
Copy link

The sway configuration (/etc/sway/config.d/50-openSUSE.conf) uses pamixer to control the volume, however it is not included in the pattern (running Tumbleweed).

After manually installing with zypper, everything works as expected

@jubalh
Copy link
Member

jubalh commented Jan 18, 2021

How did you install openSUSEway?
https://build.opensuse.org/package/view_file/X11:Wayland/openSUSEway/openSUSEway.spec?expand=1 line 51 adds pamixer.

@dive-deeper
Copy link
Author

Sorry, I confused sway-branding-openSUSE with openSUSEway (I installed the former). I am new to openSUSE so I don't know if you are also in charge of the patterns/branding/wiki but here are a couple suggestions in case any of them is possible:

  • Move pamixer to sway-branding-openSUSE: The sway configuration file that uses pamixer is included in this package and other dependencies like pavucontrol and brightnessctl are required/specified there too.
  • Change the wiki (https://en.opensuse.org/Sway) to recommend installing openSUSEway instead of sway-branding-openSUSE.

@denisok
Copy link
Contributor

denisok commented Jan 18, 2021

Hi @dionisiovj,

nice catch. I would further separate conf file, so pamixer part would be installed only with openSUSEway, so it wouldn't be confusing for ppl that just want some visual "sway" branding only.

Thanks,
Denys

@denisok denisok self-assigned this Jan 18, 2021
@denisok denisok added the bug Something isn't working label Jan 18, 2021
@denisok denisok added this to To do in openSUSE way via automation Jan 18, 2021
@denisok denisok moved this from To do to In progress in openSUSE way Jan 19, 2021
@denisok
Copy link
Contributor

denisok commented Jan 19, 2021

looked on specs and decided that right way to go is to add dependencies to spec as @dionisiovj suggested.
Here are missed dependencies (from conf file) added:
https://build.opensuse.org/request/show/864374

If there would be no objection or some review - I would land it tomorrow.

@jubalh
Copy link
Member

jubalh commented Jan 19, 2021

Did you remove it (and the config) from sway-branding-openSUSE ?

@denisok
Copy link
Contributor

denisok commented Jan 19, 2021

I added missed packages to the sway-branding-openSUSE, it doesn't affect standard sway patterns.
That conf also installed only with sway-branding-openSUSE.

@jubalh
Copy link
Member

jubalh commented Jan 19, 2021

What about:

I would further separate conf file, so pamixer part would be installed only with openSUSEway, so it wouldn't be confusing for ppl that just want some visual "sway" branding only.

Sounded reasonable to me.

@denisok
Copy link
Contributor

denisok commented Jan 19, 2021

Sounded reasonable to me.

I looked into it, and there is already brightness control and etc. So actually it customizes Sway in a good way.

openSUSEway is more about DE env, including browser and etc.

Removing wob, brightness, pamixer and other stuff leaves almost none branding Sway experience.

@denisok
Copy link
Contributor

denisok commented Jan 20, 2021

OK, it is is on its way to Factory: https://build.opensuse.org/request/show/864611

@denisok denisok closed this as completed Jan 20, 2021
openSUSE way automation moved this from In progress to Done Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
openSUSE way
  
Done
Development

No branches or pull requests

3 participants