Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_source: skip all checks for 00* packages #1463

Merged
merged 1 commit into from Mar 15, 2018

Conversation

kraih
Copy link
Member

@kraih kraih commented Mar 15, 2018

This one was requested by @coolo. All checks should be skipped for 00* packages.

@jberry-suse
Copy link
Contributor

$ ./check_source.py -A ibs --dry --debug id 158592
[I] checking 158592
[I] home:eeich:branches:SUSE:SLE-15:GA/000package-groups@4 -> SUSE:SLE-15:GA/000package-groups
[I] 158592 accepted: Skipping all checks for 00* packages
[D] 158592 review not changed

vs without PR

$ ./check_source.py -A ibs --dry --debug id 158592
[I] checking 158592
[I] home:eeich:branches:SUSE:SLE-15:GA/000package-groups@4 -> SUSE:SLE-15:GA/000package-groups
[I] 158592 declined: A package submitted as 000package-groups has to build as 'Name: 000package-groups' - found Name 'None'
[D] 158592 review not changed

Assuming no other workflows surrounding 000* packages that would conflict it looks fine.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 30.46% when pulling d991c97 on kraih:sle_00_packages into 3bd6833 on openSUSE:master.

@coolo coolo merged commit cb08861 into openSUSE:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants