Detect if a cycle provides a new package, if not, ignore the cycle. #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @DimStar77 @coolo |
|
I can't help reviewing this |
|
I think the code changes themselves make sense, but the warning should be put into some comment on the staging project; as the repo-checker runs in a loop over everything, there is close to no way anybody would see this warning if it happens (which would mean we could as well just not warn at all). |
|
@DimStar77 You are right.
|
aplanas
added a commit
that referenced
this pull request
Feb 12, 2015
Detect if a cycle provides a new package, if not, ignore the cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.