Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaper.py: indicate if origin differs from the expected origin. #634

Merged
merged 1 commit into from Jan 12, 2017

Conversation

jberry-suse
Copy link
Contributor

Minor and perhaps others have a better idea for wording, but I find myself squinting to see if the origin has changed when reading the comment.

Example output:

INFO:leaper.py:checking 448728
INFO:leaper.py:SUSE:SLE-12-SP2:Update/libzypp.3458@6256a456cdd115084ec37121e16af717 -> openSUSE:Leap:42.3/libzypp
INFO:leaper.py:expected origin is 'SUSE:SLE-12-SP2:Update' (unchanged)

Could make it more like a sentence: origin matches the expected origin '...' and origin (does not match|differs from) the expected origin '...'.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.816% when pulling 6275fc5 on jberry-suse:origin-changed into d21dbfb on openSUSE:master.

@jberry-suse
Copy link
Contributor Author

Using startswith(), this will indicate origin openSUSE:Leap:42.2 is unchanged from openSUSE:Leap:42.2:Update which seems consistent with the logic and handling. Alternatively, this could be replaced with equals check.

@lnussel lnussel merged commit d72ef36 into openSUSE:master Jan 12, 2017
@jberry-suse jberry-suse deleted the origin-changed branch February 9, 2017 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants