Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port patterns from 18_HTTP_send_file.rule #23

Closed
dmajda opened this issue Sep 19, 2011 · 2 comments
Closed

Port patterns from 18_HTTP_send_file.rule #23

dmajda opened this issue Sep 19, 2011 · 2 comments
Labels
Milestone

Comments

@dmajda
Copy link
Contributor

dmajda commented Sep 19, 2011

We need to port patterns form the rules/18_HTTP_send_file.rule file from the old scanner:

Desc: HTTP send file to Client (MIME-Sniffing, Info disclosure)

# impact        CWE identifier          regex
medium          CWE-115,CWE-200         send_file.*:disposition\s*=>\s*\'inline\'
medium          CWE-115,CWE-200         send_data.*:disposition\s*=>\s*\'inline\'
high            CWE-201                 send_file.*params\s*\[
@dmajda
Copy link
Contributor Author

dmajda commented Aug 2, 2012

medium          CWE-115,CWE-200         send_file.*:disposition\s*=>\s*\'inline\'
medium          CWE-115,CWE-200         send_data.*:disposition\s*=>\s*\'inline\'

Implemented by XssSendCheck.

@LTe The check as it is written now only finds send_file and send_data calls with one option. For example, this call won't be found:

send_file '/path/to.jpeg', :type => 'image/jpeg', :disposition => 'inline'

Could you please extend it to find calls with more options too?

high            CWE-201                 send_file.*params\s*\[

@LTe Not implemented?

@dmajda
Copy link
Contributor Author

dmajda commented Aug 6, 2012

Issues fixed by #91, closing.

@dmajda dmajda closed this as completed Aug 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant