Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

booking-window - opportunity-in-range-c1-c2 - checkout when within booking window #234

Closed
lukedawilson opened this issue Oct 13, 2020 · 0 comments · Fixed by #238
Closed

booking-window - opportunity-in-range-c1-c2 - checkout when within booking window #234

lukedawilson opened this issue Oct 13, 2020 · 0 comments · Fixed by #238
Assignees
@lukedawilson
Labels
test-request Request for a new test
Projects
OpenActive Test Suite

Comments

@lukedawilson
Copy link
Contributor

Feature

booking-window

A list of current features can be found here.

Use Case

See validFromBeforeStartDate in the spec.

Why this hasn't been covered by existing tests

Existing tests don't mandate that a validFromBeforeStartDate be specified in the criteria set.

Additional context

N/A
@lukedawilson lukedawilson added the test-request Request for a new test label Oct 13, 2020
@lukedawilson lukedawilson self-assigned this Oct 13, 2020
@lukedawilson lukedawilson linked a pull request Oct 13, 2020 that will close this issue
feat(named-leasing): Add lease-opportunity-capacity-update test (#211) #233
Closed
@lukedawilson lukedawilson added this to To do in OpenActive Test Suite via automation Oct 13, 2020
@lukedawilson lukedawilson moved this from To do to In progress in OpenActive Test Suite Oct 13, 2020
@lukedawilson lukedawilson linked a pull request Oct 14, 2020 that will close this issue
feat(booking-window): Add opportunity-in-range-c1-c2 test #238
Merged
OpenActive Test Suite automation moved this from In progress to Done Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedawilson lukedawilson

Labels
test-request Request for a new test
Projects
OpenActive Test Suite
  
Done
Milestone
No milestone
1 participant
@lukedawilson