[AMD] Cleanup AccelerateAMDMatmulPass and enable more tests #3025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarman
force-pushed
the
mfma_casts_fix2
branch
2 times, most recently
from
d3919c6
to
2d21b0d
Compare
Jokeren
changed the title
binarman
force-pushed
the
mfma_casts_fix2
branch
from
2d21b0d
to
126b158
Compare
|
/run-amd-tests |
binarman
commented
Jan 29, 2024
Comment on lines
2520
to
2525
| if (M, N, K) in [(64, 128, 128)]: | ||
| pytest.skip(f"test_dot{(M, N, K)} not supported on HIP: memory out of resource.") |
There was a problem hiding this comment.
Did not enable this test, because LDS size is not sufficient.
Looking for solution
This PR cleans up some tests and reenables more dot tests
binarman
force-pushed
the
mfma_casts_fix2
branch
from
126b158
to
1452892
Compare
zhanglx13
approved these changes
Jan 29, 2024
binarman
added a commit
to binarman/triton
that referenced
this pull request
Apr 2, 2024
…ang#3025) This PR cleans up some tests and reenables more dot tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up some tests and reenables more dot tests