Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on Mac OS #34

Closed
iamarya2k24 opened this issue Oct 20, 2021 · 5 comments
Closed

Build fails on Mac OS #34

iamarya2k24 opened this issue Oct 20, 2021 · 5 comments

Comments

@iamarya2k24
Copy link

arya@Aryas-Mac-mini goplay2 % neofetch
                    'c.          arya@Aryas-Mac-mini.local
                 ,xNMM.          -------------------------
               .OMMMMo           OS: macOS 11.6 20G165 arm64
               OMMM0,            Host: Macmini9,1
     .;loddo:' loolloddol;.      Kernel: 20.6.0
   cKMMMMMMMMMMNWMMMMMMMMMM0:    Uptime: 1 hour, 18 mins
 .KMMMMMMMMMMMMMMMMMMMMMMMWd.    Packages: 126 (brew)
 XMMMMMMMMMMMMMMMMMMMMMMMX.      Shell: zsh 5.8
;MMMMMMMMMMMMMMMMMMMMMMMM:       Resolution: 1920x1080
:MMMMMMMMMMMMMMMMMMMMMMMM:       DE: Aqua
.MMMMMMMMMMMMMMMMMMMMMMMMX.      WM: Quartz Compositor
 kMMMMMMMMMMMMMMMMMMMMMMMMWd.    WM Theme: Blue (Dark)
 .XMMMMMMMMMMMMMMMMMMMMMMMMMMk   Terminal: iTerm2
  .XMMMMMMMMMMMMMMMMMMMMMMMMK.   Terminal Font: Monaco 12
    kMMMMMMMMMMMMMMMMMMMMMMd     CPU: Apple M1
     ;KMMMMMMMWXXWMMMMMMMk.      GPU: Apple M1
       .cooc,.    .,coo:.        Memory: 1381MiB / 8192MiB




arya@Aryas-Mac-mini goplay2 % brew install portaudio fdk-aac go
Updating Homebrew...
Warning: portaudio 19.7.0 is already installed and up-to-date.
To reinstall 19.7.0, run:
  brew reinstall portaudio
Warning: fdk-aac 2.0.2 is already installed and up-to-date.
To reinstall 2.0.2, run:
  brew reinstall fdk-aac
Warning: go 1.17.2 is already installed and up-to-date.
To reinstall 1.17.2, run:
  brew reinstall go

arya@Aryas-Mac-mini goplay2 % go build
# goplay2/codec
codec/aac.go:32:10: fatal error: 'aacdecoder_lib.h' file not found
#include "aacdecoder_lib.h"
         ^~~~~~~~~~~~~~~~~~
1 error generated.
@Frulko
Copy link

Frulko commented Oct 23, 2021

Hi,
I just tried to build the project and have the same issue.

It's seems to be a path error for finding aacdecoder_lib.h
After exploring where the lib was stored with pkg-config --cflags fdk-aac and the result : /usr/local/Cellar/fdk-aac/2.0.2/include.

The header file is not inside the at the root of this path but inside the folder fdk-aac

You could change the file codec/aac.go at line 32 from #include "aacdecoder_lib.h" to #include "fdk-aac/aacdecoder_lib.h" like ... two lines above for linux compile flag.

Moreother there is a pull request open for that : #30

But today like some people my iPhone is updated to iOS 15 and we are unable to pair iOS 15 with Airplay2 instance of goplay2 (#29) for the moment. Hope this could work one day :)

@iamarya2k24
Copy link
Author

Build was successful with your changes, thanks! And yes it doesn't work with iOS 15 :(

@iamarya2k24
Copy link
Author

Closed the issue for now, as the fix can be found via issue search and the problem is already being tracked.

@Halopend
Copy link

@meta-n4vn33t I would suggest adding
#elif defined APPLE
#include "fdk-aac/aacdecoder_lib.h"
#else
to split the difference and avoid people having to search.

@iamarya2k24
Copy link
Author

@meta-n4vn33t I would suggest adding #elif defined APPLE #include "fdk-aac/aacdecoder_lib.h" #else to split the difference and avoid people having to search.

ya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants