-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify test_light_interception #40
Comments
It is my understanding that the test for shifts in light interception is only conducted for the main stem of the plant n°1. Is that correct @christian34 ? |
I add test for all axes in #38 |
The test is only conducted on a few days (which probably makes it a lot faster). Unfortunately it also means that the bug can be present without being detected. I think the test should be conducted on the whole simulation (nbj = 325 instead of 165). |
I think it would be good to refine the test to check for maximum variation instead of mean variation, because when the bug is present, important shifts only occur on a few days. |
done in #38 |
The test for shifts in light interception should be corrected for day to day variation of the input PAR
The text was updated successfully, but these errors were encountered: