Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify test_light_interception #40

Closed
Emblanc opened this issue Apr 5, 2018 · 5 comments
Closed

Modify test_light_interception #40

Emblanc opened this issue Apr 5, 2018 · 5 comments

Comments

@Emblanc
Copy link
Collaborator

Emblanc commented Apr 5, 2018

The test for shifts in light interception should be corrected for day to day variation of the input PAR

@Emblanc
Copy link
Collaborator Author

Emblanc commented Apr 10, 2018

It is my understanding that the test for shifts in light interception is only conducted for the main stem of the plant n°1. Is that correct @christian34 ?
If that is indeed the case, I think the test should be modified.
When the bug is present (i.e. when there are important changes in the intercepted PAR between one day and the next day), it does not affect all the plants and all tillers. If the test is only made on 1 axe of 1 plant, the bug can be present without being detected.

@christian34
Copy link
Contributor

I add test for all axes in #38

@Emblanc
Copy link
Collaborator Author

Emblanc commented Apr 13, 2018

The test is only conducted on a few days (which probably makes it a lot faster). Unfortunately it also means that the bug can be present without being detected. I think the test should be conducted on the whole simulation (nbj = 325 instead of 165).

@Emblanc
Copy link
Collaborator Author

Emblanc commented Apr 13, 2018

I think it would be good to refine the test to check for maximum variation instead of mean variation, because when the bug is present, important shifts only occur on a few days.

@christian34
Copy link
Contributor

done in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants