Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

uniform the form of dependent versions in Cargo.toml & reorganize the order of use declarations #56

Closed
wants to merge 2 commits into from
Closed

uniform the form of dependent versions in Cargo.toml & reorganize the order of use declarations #56

wants to merge 2 commits into from

Conversation

ZizhengBian
Copy link
Collaborator

commit 0ed2d60 (HEAD -> jason/better-crate-version, origin/jason/better-crate-version)
Author: Zizheng Bian zizheng.bian@linux.alibaba.com
Date: Fri Feb 18 19:24:52 2022 +0800

refactor: reorganize the order of `use` declarations

uniform the order of `use` declarations by the order of std, other crates, and
current crate.

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>

commit 399e133
Author: Zizheng Bian zizheng.bian@linux.alibaba.com
Date: Fri Feb 18 19:15:48 2022 +0800

refactor: uniform the form of dependent versions in Cargo.toml

Use semver without any operator instead of other forms of dependents' version.

Note: semver without any operator is equivalent to the caret form.

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>

@ZizhengBian
refactor: uniform the form of dependent versions in Cargo.toml
399e133 
Use semver without any operator instead of other forms of dependents' version.

Note: semver without any operator is equivalent to the caret form.

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
@ZizhengBian
refactor: reorganize the order of use declarations
b6bd14e 
uniform the order of `use` declarations by the order of std, other crates, and
current crate.

Signed-off-by: Zizheng Bian <zizheng.bian@linux.alibaba.com>
@codecov
Copy link

codecov bot commented Feb 18, 2022 •
edited

Codecov Report

Merging #56 (b6bd14e) into main (6b79564) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files          23       23           
  Lines        3350     3350           
=======================================
  Hits         3022     3022           
  Misses        328      328
Impacted Files Coverage Δ
crates/db-allocator/src/lib.rs 88.57% <ø> (ø)
crates/db-arch/src/x86_64/cpuid/mod.rs 90.90% <ø> (ø)
crates/db-arch/src/x86_64/regs.rs 71.42% <ø> (ø)
crates/db-boot/src/x86_64/mptable.rs 91.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b79564...b6bd14e. Read the comment docs.

studychao
studychao reviewed Feb 18, 2022
View reviewed changes
crates/db-arch/src/x86_64/cpuid/mod.rs
mod brand_string;
mod common;
mod transformer;
pub mod cpu_leaf;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you put cpu_leaf here?

jiangliu
jiangliu reviewed Feb 18, 2022
View reviewed changes
crates/db-address-space/Cargo.toml
arc-swap = ">=0.4.8"
libc = ">=0.2.39"
nix = ">=0.15.0"
arc-swap = "1.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to be careful to adjust the dependency version.

jiangliu
jiangliu reviewed Feb 18, 2022
View reviewed changes
crates/db-address-space/Cargo.toml
thiserror = "1"
vmm-sys-util = ">=0.8.0"
vmm-sys-util = "0.9.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This locks down vmm-sys-util to 0.9.x.

jiangliu
jiangliu reviewed Feb 18, 2022
View reviewed changes
crates/db-address-space/Cargo.toml
nix = ">=0.15.0"
arc-swap = "1.5.0"
libc = "0.2.0"
nix = "0.23.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this locks nix to 0x.23.x.

jiangliu
jiangliu reviewed Feb 18, 2022
View reviewed changes
crates/db-boot/Cargo.toml
@@ -12,4 +12,4 @@ readme = "README.md"
[dependencies]
thiserror = "1"
vm-memory = { version = "0.7.0", features = ["backend-mmap"] }
libc = "0.2.39"
libc = "0.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inconsistent to "libc = "0.2.0"

We may need to work a rule for dependency

@jiangliu jiangliu marked this pull request as draft February 19, 2022 08:35
@ZizhengBian
Copy link
Collaborator Author

It seems that we need to discuss a set of specifications first

@ZizhengBian ZizhengBian linked an issue Feb 20, 2022 that may be closed by this pull request
Simplify & unify the expression of version number in Cargo.toml #29
Closed
@jiangliu
Copy link
Member

It seems that we need to discuss a set of specifications first

any update on this?

@ZizhengBian
Copy link
Collaborator Author

It seems that we need to discuss a set of specifications first

any update on this?

I haven't had time to do it

@studychao
Copy link
Member

I will close thie PR.
Please reopen it when you have time to look at it. @ZizhengBian

@studychao studychao closed this May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jiangliu jiangliu jiangliu left review comments

@studychao studychao studychao left review comments

@wllenyj wllenyj Awaiting requested review from wllenyj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify & unify the expression of version number in Cargo.toml
3 participants
@ZizhengBian @jiangliu @studychao