This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
allcator: change &mut self -> &mut self to mut self -> self #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studychao
force-pushed
the
chao/fix_allocator_bug
branch
2 times, most recently
from
83ea5ef
to
0347e19
Compare
|
Fix test case fails in #77. |
Previous constraint implemented &mut self -> &mut self for changing max, min, etc. But this cause problem for code like ``` let constraint = Constraint::new(...).max(...).min(...); ``` This code creates a Constraint and returns the mut reference to it, but there will be no one take the ownership of that Constraint so it'll be dropped and cannot be used later. Since temporary value is freed at the end of this statement, it is not a ideal case for us. Signed-off-by: Chao Wu <chaowu@linux.alibaba.com>
studychao
force-pushed
the
chao/fix_allocator_bug
branch
from
0347e19
to
c5611fb
Compare
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 90.40% 90.21% -0.19%
==========================================
Files 29 36 +7
Lines 3771 4895 +1124
==========================================
+ Hits 3409 4416 +1007
- Misses 362 479 +117
Continue to review full report at Codecov.
|
jiangliu
approved these changes
Mar 7, 2022
|
Why does the code coverage drop? |
Don't know. There is no new code added or old UT deleted |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous constraint implemented &mut self -> &mut self for changing max,
min, etc.
But this cause problem for code like
This code creates a Constraint and return the mut reference to it, but
there will be no one take the ownership of that Constraint so it'll be
dropped and cannot be used later. Since temporary value is freed at the end
of this statement, it is not a ideal case for us.
Signed-off-by: Chao Wu chaowu@linux.alibaba.com