Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Support array type #25

Open
jarcand opened this issue Jun 1, 2021 · 4 comments
Open

Support array type #25

jarcand opened this issue Jun 1, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@jarcand
Copy link

jarcand commented Jun 1, 2021

Unless I'm missing something, the spec supports array type but the parse_schema function just fails with unimplemented:

I didn't see any other bug tracking this, so thought I'd start one.

Thanks!

@sergeysova
Copy link
Member

sergeysova commented Jun 1, 2021

Hello, thank you for contribution.

can you attach an example swagger file with spec that fails? I going to implement array support

@jarcand
Copy link
Author

jarcand commented Jun 17, 2021

Here's a minimal sample I made:

openapi-with-array.yaml.txt

Here's the output when compiling:

$ RUST_BACKTRACE=1 cargo-swagg openapi-with-array.yaml
thread 'main' panicked at 'not implemented', /home/jarcand/.cargo/registry/src/github.com-1ecc6299db9ec823/swagg-0.3.0/src/highway/mod.rs:269:40
stack backtrace:
   0: rust_begin_unwind
             at /rustc/8f349be27815d43d462a32faeb270a22a68486b6/library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at /rustc/8f349be27815d43d462a32faeb270a22a68486b6/library/core/src/panicking.rs:92:14
   2: core::panicking::panic
             at /rustc/8f349be27815d43d462a32faeb270a22a68486b6/library/core/src/panicking.rs:50:5
   3: swagg::highway::parse_ref_or_schema
   4: swagg::highway::parse_ref_or_schema
   5: swagg::to_string
   6: cargo_swagg::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

@sergeysova
Copy link
Member

Thank you. I'm going to review and fix it

@sergeysova sergeysova added the bug Something isn't working label Jun 22, 2021
@jayvdb
Copy link
Contributor

jayvdb commented Oct 22, 2022

This is a significant blocker for adoption of actix-swagger.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants